From 456b0779bbffeb816fe6b8a6b953f0b9749ba93c Mon Sep 17 00:00:00 2001
From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Thu, 20 Feb 2020 15:15:54 +0100
Subject: [PATCH] JsonRpcConnection PKI: Document swalled exception

---
 lib/remote/jsonrpcconnection-pki.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/remote/jsonrpcconnection-pki.cpp b/lib/remote/jsonrpcconnection-pki.cpp
index b8fda041a..4f9938091 100644
--- a/lib/remote/jsonrpcconnection-pki.cpp
+++ b/lib/remote/jsonrpcconnection-pki.cpp
@@ -57,9 +57,7 @@ Value RequestCertificateHandler(const MessageOrigin::Ptr& origin, const Dictiona
 
 	try {
 		signedByCA = VerifyCertificate(cacert, cert);
-	} catch (const std::exception& ex) {
-
-	}
+	} catch (const std::exception&) { } /* Swallow the exception on purpose, cacert will never be a non-CA certificate. */
 
 	Log(LogInformation, "JsonRpcConnection")
 		<< "Received certificate request for CN '" << cn << "'"