From e727675aaf525311171f92c52f72be15d80f5c39 Mon Sep 17 00:00:00 2001 From: Julian Brost Date: Wed, 13 Jan 2021 14:43:40 +0100 Subject: [PATCH] Remove incorrect assertion in ConfigItem::ActivateItems There is an assertion that after activating items, all these items are active, which sounds reasonable at first. However, with concurrent API queries, some of these could already be deleted and therefore be deactivated again. --- lib/config/configitem.cpp | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/lib/config/configitem.cpp b/lib/config/configitem.cpp index 0328a4f9a..f3272a2f5 100644 --- a/lib/config/configitem.cpp +++ b/lib/config/configitem.cpp @@ -697,17 +697,6 @@ bool ConfigItem::ActivateItems(const std::vector& newItems, boo } } -#ifdef I2_DEBUG - for (const ConfigItem::Ptr& item : newItems) { - ConfigObject::Ptr object = item->m_Object; - - if (!object) - continue; - - ASSERT(object && object->IsActive()); - } -#endif /* I2_DEBUG */ - if (!silent) Log(LogInformation, "ConfigItem", "Activated all objects.");