Commit graph

1756 commits

Author SHA1 Message Date
Lord Hepipud
e840d81148 Ensure numbers are printed as numeric with . 2021-05-31 15:58:42 +02:00
Lord Hepipud
955c2b31f5
Merge pull request #267 from Icinga:feature/add_colon_if_not_set
Fix: Double colon is added, even if check name already contains it
2021-05-31 15:41:56 +02:00
Lord Hepipud
eb81a12963 Fix double colon if added by check 2021-05-31 15:39:52 +02:00
Lord Hepipud
67a8908cb2
Merge pull request #266 from Icinga:fix/only_add_maximum_if_set
Fix: Perf data should only add maximum if it was set before
2021-05-31 15:26:27 +02:00
Lord Hepipud
6537277d89 Fix perf data to add maximum if set only 2021-05-31 15:24:53 +02:00
Lord Hepipud
3cce6caed1
Merge pull request #265 from Icinga:fix/negative_time_spawn_microsecond_addition_and_test_numeric_update
Fix: Test-Numeric allows no negative value and TimeSpan conversion ignores negatives and microseconds

Fixes `Test-Numeric` to now accept negative numeric values and als fixes errors, causing `.` to be allowed multiple times. `ConvertFrom-TimeSpan` now properly prints on negative values if the time provided is positive or negative and also prints microseconds as `us` in case the value is loer than `1ms`
2021-05-31 11:02:54 +02:00
Lord Hepipud
8b1441df3a Fixes Test-Numeric for negative, adds microseconds 2021-05-31 10:55:49 +02:00
Lord Hepipud
7ade142966
Merge pull request #264 from Icinga:feature/add_first_handling_for_network_speed_units
Feature: Adds first handling for Framework link speeds

Adds initial handling for handling link speeds or anything else by using new units and conversions, which were formerly used inside the Network plugin and corresponding provider.
2021-05-29 14:27:19 +02:00
Lord Hepipud
28b78c1ec1 Adds first handling for Framework link speeds 2021-05-29 14:27:03 +02:00
Lord Hepipud
411ce69223
Merge pull request #263 from Icinga:fix/remove_colon_at_package_message_without_content
Fix: Removes colon at the end of the packlage summary

Removes the `:` at the end of a package message, in case no additional text input is present on this line
2021-05-29 12:59:52 +02:00
Lord Hepipud
f9012f3094 Fixes colon at package message and on no message 2021-05-29 12:57:41 +02:00
Lord Hepipud
9b5c64eacb
Merge pull request #262 from Icinga:fix/another_input_value_to_decimal_fix
Fix: Input value from check objects was sometimes not properly converted to decimal

Fixes input value conversion to `decimal` for check input values.
2021-05-29 11:36:07 +02:00
Lord Hepipud
050461d802 Fixes an issue with input value decimal conversion 2021-05-29 11:33:44 +02:00
Lord Hepipud
d78a7a77b8
Merge pull request #261 from Icinga:fix/perfdata_for_unprocessed_checks_was_not_added
Fix: Performance Data was not written for checks which were not compared to a threshold

Fixes an issue for Performance Data, which mainly occurs for hidden packages and checks, as there was no action taking place to "use" the provided value in someway. This caused the performance data object not being generated and threfor was not added to the check output.
2021-05-29 11:22:38 +02:00
Lord Hepipud
8c48ed570b Fixes perfdata not written for unprocessed checks 2021-05-29 11:20:10 +02:00
Lord Hepipud
0a28e25ab0
Merge pull request #260 from Icinga:fix/numeric_conversion_for_comparison
Fix: Numeric converison to comparing thresholds is incorrect

Fixes values to be transformed properly to `decimal` to compare them against thresholds provided
2021-05-29 10:57:54 +02:00
Lord Hepipud
f6480e37c6 Fixes numeric converison to comparing thresholds 2021-05-29 10:55:56 +02:00
Lord Hepipud
53f75e8252
Merge pull request #259 from Icinga:fix/properly_format_time_span_string_values
Fix: Missing rounding for time span values

We should round time span values converted to string to transform `22,8934057h` to `22,89h` for example
2021-05-29 00:08:58 +02:00
Lord Hepipud
1761eedcad Fix missing rounding for time span values 2021-05-29 00:07:25 +02:00
Lord Hepipud
8288cc4833
Merge pull request #258 from Icinga:fix/header_summary_considers_hidden_packages
Fix: Header summary should not include hidden packages/elements

Fixes header summary to no longer count in hidden elements for status counts
2021-05-28 23:52:41 +02:00
Lord Hepipud
e63bf3cbea Fixes header summary, no longer counts hidden 2021-05-28 23:50:54 +02:00
Lord Hepipud
b6c699f5de
Merge pull request #257 from Icinga:fix/threshold_conversion_generic_unit_exception
Fix: Unhandled units might cause exception on maximum compare

Unhandled units like `c` are causing exceptions, in case they are used as maximum or base value.
2021-05-28 23:39:03 +02:00
Lord Hepipud
6b3f27fae1 Fixes unhandled units might cause exception 2021-05-28 23:36:57 +02:00
Lord Hepipud
72c1495165
Merge pull request #255 from Icinga:fix/eventlog_analyer_for_multi_array_result
Fix: Array handling on log analyser and adds timestamp to output

Improves `Show-IcingaEventLogAnalysis` by properly handling array logs and only processing the first entry while also adding timestamps for the newest and oldest eventog entry

Fixes #246
2021-05-28 21:10:02 +02:00
Lord Hepipud
37596459ab Fix array handling on log analyser; Adds timestamp 2021-05-28 21:09:16 +02:00
Lord Hepipud
7ddc77c494
Merge pull request #249 from Icinga:feature/rewrite_exception_handler
Feature: Rewrite exception handler

Improves internal exception handler to get rid if misplaced `:` and adds all fields properly
2021-05-28 21:08:40 +02:00
Lord Hepipud
71f54b29e7
Merge branch 'master' into feature/rewrite_exception_handler 2021-05-28 21:08:17 +02:00
Lord Hepipud
42626dab45 Rewrite exception handler 2021-05-28 21:06:33 +02:00
Lord Hepipud
3ceaa22646
Merge pull request #247 from Icinga:feature/rewrite_plugin_execution
Feature: Re-Write execution of checks

We re-dessigned the handling on how checks are executed internally, to make configuration, extension and adding future features even more easier.

What is new:
* Allows to specify generic % values for thresholds, in case you added the `BaseValue` argument with the basic value for your input value to compare them as % for each other: `New-IcingaCheck -BaseValue $partition.Size`
* Allows to check for defined thresholds intervalls by the Icinga for Windows daemon, by adding `-ThresholdInterval 15m` for example to your check execution: `Invoke-IcingaCheckCPU -ThresholdInterval 1m -Warning 60%`
* Values of output data which are defined as Bytes, seconds or anything related will now always be properly translated for better readability
* Provided translations for example service states are anything related are improvement and will always apply now
* There is an optional `-AddSummary` header available, which now adds in addition to the current package header the number of Unknown, Critical, Warning or Ok services (requires Plugin update)
* In case a check is not ok, it will not added to the first package including the current value of the check for better overview
* The check functions `SetOk()`, `SetWarning()`, `SetCritical()`, `SetUnknown()` for `New-IcingaCheck` now support a input message as first value to print informations on why the check is in this state, including a `bool` value as second argument, which will look the entire check object in this state, making it unmodifyable in case it is set to `$TRUE`: `$check.SetUnknown('Your partition could not be read', $TRUE) | Out-Null`
2021-05-28 21:02:09 +02:00
Lord Hepipud
a9126ce402 Re-Write execution of checks 2021-05-28 20:08:23 +02:00
Lord Hepipud
b782d44242
Merge pull request #256 from Icinga:fix/director_self_service_api_wizard
Fix: Self Service for removed hosts/keys inside Icinga Director

Fixes error while using Icinga Director Self-Service API, in case the host or host API key was deleted inside the Icinga Director and the installation wizard was called with the correct template key, while the old host key was still present inside the Icinga for Windows configuration
2021-05-27 16:15:17 +02:00
Lord Hepipud
7f10d34ff0 Fixes self service for removed hosts/keys 2021-05-27 14:13:25 +02:00
Lord Hepipud
0228d302ed Updates changelog 2021-05-25 13:10:17 +02:00
Lord Hepipud
221973a964
Merge pull request #245 from haxtibal/bugfix/find_pfx_cert
Fix loading certificate from .pfx file
2021-05-25 13:08:55 +02:00
Lord Hepipud
b6ce0c40e6
Merge pull request #236 from Icinga:feature/stop_icinga_agent_during_framework_upgrade
Feature: Stop Icinga Agent during Framework upgrade

In some rare cases it can happen that during the upgrade of the Icinga PowerShell Framework, files are still used caused by the Icinga Agent running in the background.
To remove this impact, we will now stop the Icinga Agent in case it is running before upgrading the Framework and starting the Icinga Agent again, in case it was started before.
2021-05-25 10:10:09 +02:00
Lord Hepipud
acb8cbaf5c Stops Icinga Agent during Framework upgrade 2021-05-25 10:09:14 +02:00
Lord Hepipud
476de7d9cc
Merge pull request #254 from Icinga/bugfix/make-exception-enums-not-plugin-specific
Bugfix: Make exception enums not plugin specific
2021-05-22 10:41:39 +02:00
Yonas Habteab
581e0d1a56 Make exception enums not plugin specific 2021-05-21 17:51:59 +02:00
Lord Hepipud
56c2ab4188
Merge pull request #252 from Icinga:fix/improve_module_error_handling
Feature: Inform the user if plugins are executed which are not meeting dependency requirements

Improve error handling on plugin execution by informing the user if the plugin is simply not installed or the entire module was not loaded because of errors or missing dependencies

Fixes #250
2021-05-21 11:37:31 +02:00
Lord Hepipud
47203d39c5 Feature: Inform the user if plugins are executed which are not meeting dependency requirements
Fixes #250
2021-05-21 11:02:51 +02:00
Lord Hepipud
0a09d63cbd
Merge pull request #248 from Icinga/feature/improve_test_for_performance_counter_categories
Feature: Improve test if Performance Counter category exist

This will improve `Test-IcingaPerformanceCounterCategory` by creating an object for the Performance Counter category provided and checking if it is a valid object instead of relying on the registry which might not contain all categories in the correct language.
2021-05-21 09:38:41 +02:00
Lord Hepipud
19a6952cee Improve test if perf counter category exist 2021-05-19 15:24:48 +02:00
Lord Hepipud
d6f164410b
Merge pull request #233 from Icinga:feature/supress_console_output_except_for_plugin_data
Feature: Suppress other messages then plugin output

Adds feature to suppress any kind of console output except for plugin output and performance data, while Icinga for Windows is initialised with `Use-Icinga -Minimal`
2021-05-19 09:21:05 +02:00
Lord Hepipud
01b39ea514 Supress other messages then plugin output 2021-05-19 09:19:43 +02:00
Lord Hepipud
527b3951ba
Merge pull request #238 from Icinga:fix/Exit-IcingaExecutePlugin-throws-exception-for-localized-PerfCounters
Fix: Exit-IcingaExecutePlugin throws exception for localized PerfCounters

Encoding for REST-Api check calls was wrong during queue and while reading the result. We will now enfore UTF8 in both ways.

Fixes #232
2021-05-11 09:50:13 +02:00
Tobias Deiminger
91e37ea16c Fix loading certificate from .pfx file
If you tried this
 Use-Icinga; Get-IcingaSSLCertForSocket -CertFile "C:/my/cert.pfx"

the former code expanded like
 $FileType = Get-Item -Path "C:/my/cert.pfx";
 if ("cert.pfx" -eq '.pfx') { ... not reached ... }

and thus did not load the certificate file.

Now use GetExtension instead of Get-Item to make the .pfx check work.
2021-05-10 09:17:46 +02:00
Lord Hepipud
5f3d08ba84
Merge pull request #243 from Icinga:feature/add_stacktrace_for_plugin_execution_failure
Feature: Adds stacktrace for plugin runtime error

Adds StackTrace for exception output in case plugin execution fails.
2021-05-07 14:35:58 +02:00
Lord Hepipud
41f8b2a7e5 Adds stacktrace for plugin runtime error 2021-05-07 14:34:39 +02:00
Lord Hepipud
0b6e2235ed Exit-IcingaExecutePlugin throws exception for localized PerfCounters
Fixes #232
2021-05-04 17:36:31 +02:00
Lord Hepipud
eb5dd020b5
Merge pull request #241 from Icinga:feature/force_new_tls_versions_on_rest_api_checks
Feature: Force new TLS version for REST

Ensures we use TLS 1.1 and 1.2 for REST-Api calls, as used certificates in general are created with these.
2021-05-04 17:34:32 +02:00