upstream/icinga-powershell-framework
1
0
Fork 0
mirror of https://github.com/Icinga/icinga-powershell-framework.git synced 2026-02-03 12:19:29 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #686 from Icinga:fix/adds_certutil_output_and_improves_error_message

Browse source 
Fix: Certutil error handling and message output in case the icingaforwindows.pfx could not be created

Fixes certutil error handling and message output in case the icingaforwindows.pfx could not be created
This commit is contained in:
Lord Hepipud 2024-02-28 15:44:03 +01:00 committed by GitHub
commit a2ba3124e5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
doc/100-General/10-Changelog.md
View file

@ -14,6 +14,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
### Bugfixes
* [#683](https://github.com/Icinga/icinga-powershell-framework/pull/683) Fixes JEA installer to exclude domain from user name length check, which can easily exceed the Windows 20 digits username limit
* [#686](https://github.com/Icinga/icinga-powershell-framework/pull/686) Fixes certutil error handling and message output in case the icingaforwindows.pfx could not be created
### Enhancements

6
lib/webserver/ConvertTo-IcingaX509Certificate.psm1
View file

@ -44,14 +44,16 @@ function ConvertTo-IcingaX509Certificate()
[string]::Format(
'Certutil merge request has been completed. Certutil message:{0}{0}{1}',
(New-IcingaNewLine),
$CertUtilOutput
($CertUtilOutput | Out-String)
)
);
# If no target file exists afterwards (a valid PFX certificate)
# then throw an exception
if (-Not (Test-Path $TargetFile)) {
throw 'The specified/created certificate file could not be found.';
[string]$ErrMessage = [string]::Format('Unable to create the Icinga for Windows certificate file "icingaforwindows.pfx". Certutil output:{0}{1}', (New-IcingaNewLine), ($CertUtilOutput | Out-String));
Write-IcingaConsoleError $ErrMessage;
throw $ErrMessage;
}
# Now load the actual certificate from the path