From 46f8670427656f45e59d433670bdc17434e53e9b Mon Sep 17 00:00:00 2001 From: Lord Hepipud Date: Tue, 30 Dec 2025 16:05:40 +0100 Subject: [PATCH] Updates changelog to move 1.13.4 changes to v1.14.0 --- doc/100-General/10-Changelog.md | 13 +++---------- lib/core/windows/Get-IcingaRandomChars.psm1 | 2 +- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/doc/100-General/10-Changelog.md b/doc/100-General/10-Changelog.md index f23eaa4..4b9d8ba 100644 --- a/doc/100-General/10-Changelog.md +++ b/doc/100-General/10-Changelog.md @@ -13,6 +13,9 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic ### Bugfixes +* [#814](https://github.com/Icinga/icinga-powershell-framework/pull/814) Fixes random chars function to truly generate unpredictable character sequences and to replace `Get-Random` which is not entirely secure +* [#815](https://github.com/Icinga/icinga-powershell-framework/pull/815) Fixes a possible crash for `Test-IcingaAddTypeExist`, causing the Icinga for Windows installation to fail when third party components are checked which are malfunctioning +* [#829](https://github.com/Icinga/icinga-powershell-framework/pull/829) Fixes `Set-IcingaCacheData` to properly remove cache files in case `$null` is passed as value * [#833](https://github.com/Icinga/icinga-powershell-framework/issues/833) Fixes registry lookup for Icinga Agent installation to check if the required `DisplayName` attribute is defined before checking * [#834](https://github.com/Icinga/icinga-powershell-framework/issues/834) Fixes security catalog compilation error on non-english Windows versions, while properly skipping checks on system SID's and improves security by always adding the `SeDenyNetworkLogonRight` and `SeDenyInteractiveLogonRight` privilege section for the JEA user SID * [#835](https://github.com/Icinga/icinga-powershell-framework/pull/835) Fixes JEA compiler to always enforce a rebuild of the Framework to ensure integrity of JEA profiles @@ -25,16 +28,6 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic * [#838](https://github.com/Icinga/icinga-powershell-framework/pull/838) Enhances Icinga for Windows to never load and user PowerShell profiles * [#841](https://github.com/Icinga/icinga-powershell-framework/pull/841) Adds new [INFO] state for notice and un-checked monitoring objects -## 1.13.4 (tbd) - -[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/42) - -### Bugfixes - -* [#814](https://github.com/Icinga/icinga-powershell-framework/pull/814) Fixes random chars function to truly generate unpredictable character sequences and to replace `Get-Random` which is not entirely secure -* [#815](https://github.com/Icinga/icinga-powershell-framework/pull/815) Fixes a possible crash for `Test-IcingaAddTypeExist`, causing the Icinga for Windows installation to fail when third party components are checked which are malfunctioning -* [#829](https://github.com/Icinga/icinga-powershell-framework/pull/829) Fixes `Set-IcingaCacheData` to properly remove cache files in case `$null` is passed as value - ## 1.13.3 (2025-05-08) [Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/39) diff --git a/lib/core/windows/Get-IcingaRandomChars.psm1 b/lib/core/windows/Get-IcingaRandomChars.psm1 index 1bc97b1..a495751 100644 --- a/lib/core/windows/Get-IcingaRandomChars.psm1 +++ b/lib/core/windows/Get-IcingaRandomChars.psm1 @@ -21,7 +21,7 @@ function Get-IcingaRandomChars() # Generate random bytes $CryptoProvider.GetBytes($ByteValue); $RandomNumber = [BitConverter]::ToUInt32($ByteValue, 0); - # Ensure the random number is within the valid range to avoid maximum security + # Ensure the random number is within the valid range to ensure maximum security } while ($RandomNumber -ge $maxValid); # Calculate the index for the symbol array