upstream/icinga-powershell-framework
1
0
Fork 0
mirror of https://github.com/Icinga/icinga-powershell-framework.git synced 2026-02-03 04:09:29 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #811 from Icinga:fix/add_summary_header_for_check_compiler_not_adding_check_details

Browse source 
Fix: AddSummaryHeader not adding any check information to check package

Fixes plugin compiler not handling `AddSummaryHeader` properly for nested check packages, not adding any check information

```powershell
[WARNING] CPU Load [WARNING] Socket #0 (All must be [OK])
\_ [OK] Overall Load: 8.283808%
\_ [WARNING] Socket #0: 2 Warning 3 Ok [WARNING] Core 0, Core 2 (All must be [OK])
   \_ [WARNING] Core 0: Value 18.86168% is greater than threshold 9%
   \_ [OK] Core 1: 4.852731%
   \_ [WARNING] Core 2: Value 9.340026% is greater than threshold 9%
   \_ [OK] Core 3: 0.080795%
   \_ [OK] Core Total: 8.283808%
| totalload::ifw_cpu::load=8.283808%;9;;0;100 0_0::ifw_cpu::load=18.86168%;9;;0;100 0_1::ifw_cpu::load=4.852731%;9;;0;100 0_2::ifw_cpu::load=9.340026%;9;;0;100 0_3::ifw_cpu::load=0.080795%;9;;0;100 0_total::ifw_cpu::load=8.283808%;9;;0;100
```
This commit is contained in:
Lord Hepipud 2025-04-24 08:17:51 +02:00 committed by GitHub
commit 0ff9286d0c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
doc/100-General/10-Changelog.md
View file

@ -25,6 +25,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
* [#787](https://github.com/Icinga/icinga-powershell-framework/pull/787) Fixes the return value in case the `Agent` component could not be installed from `$FALSE` to `null`
* [#796](https://github.com/Icinga/icinga-powershell-framework/issues/796) [#798](https://github.com/Icinga/icinga-powershell-framework/issues/798) Fixes an issue with the new check handling, which did not properly convert values from checks to the correct performance data values and base values in some cases
* [#797](https://github.com/Icinga/icinga-powershell-framework/issues/797) Fixes plugins throwing `UNKNOWN` in case `-TresholdInterval` is used for Metrics over Time, when checks are newly registered and checked, before the first MoT is executed and collected
* [#809](https://github.com/Icinga/icinga-powershell-framework/issues/809) Fixes plugin compiler not handling `AddSummaryHeader` properly for nested check packages, not adding any check information
### Enhancements

4
lib/icinga/plugin/New-IcingaCheckPackage.psm1
View file

@ -101,8 +101,8 @@ function New-IcingaCheckPackage()
$CheckSummary = New-Object -TypeName 'System.Text.StringBuilder';
[bool]$HasContent = $FALSE;
# Only apply this to the top parent package
if ($this.__GetIndention() -eq 0) {
# Always apply this to the first package or if we specify AddSummaryHeader
if ($this.__GetIndention() -eq 0 -Or $this.AddSummaryHeader) {
if ($this.__UnknownChecks.Count -ne 0) {
$UnknownChecks = [string]::Format(' [UNKNOWN] {0}', ([string]::Join(', ', $this.__UnknownChecks)));
$CheckSummary.Append(