upstream/icinga-powershell-framework
1
0
Fork 0
mirror of https://github.com/Icinga/icinga-powershell-framework.git synced 2025-12-20 23:00:35 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #248 from Icinga/feature/improve_test_for_performance_counter_categories

Browse source 
Feature: Improve test if Performance Counter category exist

This will improve `Test-IcingaPerformanceCounterCategory` by creating an object for the Performance Counter category provided and checking if it is a valid object instead of relying on the registry which might not contain all categories in the correct language.
This commit is contained in:
Lord Hepipud 2021-05-21 09:38:41 +02:00 committed by GitHub
commit 0a09d63cbd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
doc/31-Changelog.md
View file

@ -19,6 +19,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
* [#235](https://github.com/Icinga/icinga-powershell-framework/pull/235) Adds new Cmdlet `Show-IcingaEventLogAnalysis` to get a better overview on how many log entries are present within the EventLog based on hour, minute and day average/maximum for allowing a more dynamic configuration for `Invoke-IcingaCheckEventLog`
* [#241](https://github.com/Icinga/icinga-powershell-framework/pull/241) Ensures we use TLS 1.1 and 1.2 for REST-Api calls, as used certificates in general are created with these
* [#243](https://github.com/Icinga/icinga-powershell-framework/pull/243) Adds stacktrace output for exceptions in case plugin execution fails
* [#248](https://github.com/Icinga/icinga-powershell-framework/pull/248) Improves `Test-IcingaPerformanceCounterCategory` by creating an object for the Performance Counter category provided and checking if it is a valid object instead of relying on the registry which might not contain all categories in the correct language.
### Bugfixes

12
lib/core/perfcounter/Test-IcingaPerformanceCounterCategory.psm1
View file

@ -28,9 +28,17 @@ function Test-IcingaPerformanceCounterCategory()
[string]$Category
);
$Counters = Show-IcingaPerformanceCounterCategories -Filter $Category;
if ([string]::IsNullOrEmpty($Category)) {
return $FALSE;
}
if ($Counters.Count -eq 0) {
try {
$Counter = New-Object System.Diagnostics.PerformanceCounterCategory($Category);
if ($null -eq $Counter -Or [string]::IsNullOrEmpty($Counter.CategoryType)) {
return $FALSE;
}
} catch {
return $FALSE;
}