mirror of
https://github.com/helm/helm.git
synced 2026-04-21 06:06:56 -04:00
f94bac0643
Backport of https://github.com/helm/helm/pull/6010 to dev-v3 (the description below is a copy-paste from the original v2 branch PR). As https://github.com/helm/helm/pull/6016 is now merged to dev-v3, the change is reasonably trivial. This change is an attempt to address the common problem of json number unmarshalling where any number is converted into a float64 and represented in a scientific notation on a marshall call. This behavior breaks things like: chart versions and image tags if not converted to yaml strings explicitly. An example of this behavior: k8s failure to fetch an image tagged with a big number like: $IMAGE:20190612073634 after a few steps of yaml re-rendering turns into: $IMAGE:2.0190612073634e+13. Example issue: #1707 This commit forces yaml parser to use JSON modifiers and explicitly enables interface{} unmarshalling instead of float64. The change introduced might be breaking so should be processed with an extra care. Due to the fact helm mostly dals with human-produced data (charts), we have a decent level of confidence this change looses no functionality helm users rely upon (the scientific notation). Relevant doc: https://golang.org/pkg/encoding/json/#Decoder.UseNumber Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com> Signed-off-by: Oleg Sidorov <me@whitebox.io> |
||
|---|---|---|
| .. | ||
| albatross | ||
| dependent-chart-alias | ||
| dependent-chart-helmignore | ||
| dependent-chart-no-requirements-yaml | ||
| dependent-chart-with-all-in-requirements-yaml | ||
| dependent-chart-with-mixed-requirements-yaml | ||
| frobnitz | ||
| frobnitz_backslash | ||
| joonix | ||
| mariner | ||
| moby | ||
| subpop | ||
| chartfiletest.yaml | ||
| coleridge.yaml | ||
| frobnitz-1.2.3.tgz | ||
| frobnitz_backslash-1.2.3.tgz | ||
| genfrob.sh | ||
| test-values-negative.yaml | ||
| test-values.schema.json | ||
| test-values.yaml | ||