mirror of
https://github.com/helm/helm.git
synced 2026-04-15 21:59:50 -04:00
0a5148faff
First, some notes about priority and how some code flow works. For Helm handling values, the expected order of precidence is: 1. User specified values (e.g CLI) 2. Imported values 3. Parent chart values 4. Subchart values Helm handles dependency values slightly differently. If there are dependencies in the charts folder that are not marked as dependencies all of the values, including nil values, are pulled in. If those charts are listed as a dependency in the Chart.yaml file than they are processed for import handling. Prior to the changes here, it caused nil values at the top level to NOT remove values specified. The changes: 1. The order of priority was chagned from the list above. Parnet chart values would override specifically imported values. This is due to a change from just over a year ago that introduced a bug. That was undone by changing the precidence when maps were merged. 2. To handle merging while retaining the nil values, which was causing inconsistent behavior, a new set of Merge functions were introduced. These functions are just like coalesce except that they DO NOT remove nil/null values. The new functions are used in a backward compatible manner meaning some new functions were introduced that called them. Specific issues fixed (that are known): Closes #9027 Can now delete subkeys from charts when specified in the parent. This behavior was previously inconsistent. Sometimes they could be deleted and other times it did not work. Now it is consistent. Closes #10899 Imported values (from library or other subcharts) are now used following the order above. The previous behavior was inconsistent. import-values using just a string would import them. When named with a child/parent it did not work if the parent already had a value. If string and named were mixed the imports worked if the string happened first but just for the string not the named. If the named parent/child went first then none of them worked for cases where the parent already had a value. It was inconsistent and the tests sometimes mirrored the functionality rather than expected behavior. Tests for this fall into the sub-packages and are in the template tests to verify it's happening in the output. Including having values passed at the CLI as the ultimate highest priority to be used. This relates to a fix that went in for #9940. The expected values there don't fit the precedence above where the parent value would override the imported value. That fix/change introduced more bugs. Closes #10052 This is the case where imported values using the parent/child designation just didn't work right. That has been fixed and there are tests. The underlying issue had to do with the precedence order handling. Note, a lot of tests were added. Hope we got it more right this time. Signed-off-by: Matt Farina <matt.farina@suse.com>
700 lines
19 KiB
Go
700 lines
19 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package chartutil
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"helm.sh/helm/v3/pkg/chart"
|
|
)
|
|
|
|
// ref: http://www.yaml.org/spec/1.2/spec.html#id2803362
|
|
var testCoalesceValuesYaml = []byte(`
|
|
top: yup
|
|
bottom: null
|
|
right: Null
|
|
left: NULL
|
|
front: ~
|
|
back: ""
|
|
nested:
|
|
boat: null
|
|
|
|
global:
|
|
name: Ishmael
|
|
subject: Queequeg
|
|
nested:
|
|
boat: true
|
|
|
|
pequod:
|
|
global:
|
|
name: Stinky
|
|
harpooner: Tashtego
|
|
nested:
|
|
boat: false
|
|
sail: true
|
|
ahab:
|
|
scope: whale
|
|
boat: null
|
|
nested:
|
|
foo: true
|
|
bar: null
|
|
`)
|
|
|
|
func withDeps(c *chart.Chart, deps ...*chart.Chart) *chart.Chart {
|
|
c.AddDependency(deps...)
|
|
return c
|
|
}
|
|
|
|
func TestCoalesceValues(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
c := withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "moby"},
|
|
Values: map[string]interface{}{
|
|
"back": "exists",
|
|
"bottom": "exists",
|
|
"front": "exists",
|
|
"left": "exists",
|
|
"name": "moby",
|
|
"nested": map[string]interface{}{"boat": true},
|
|
"override": "bad",
|
|
"right": "exists",
|
|
"scope": "moby",
|
|
"top": "nope",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l0": "moby"},
|
|
},
|
|
},
|
|
},
|
|
withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "pequod"},
|
|
Values: map[string]interface{}{
|
|
"name": "pequod",
|
|
"scope": "pequod",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l1": "pequod"},
|
|
},
|
|
},
|
|
},
|
|
&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "ahab"},
|
|
Values: map[string]interface{}{
|
|
"global": map[string]interface{}{
|
|
"nested": map[string]interface{}{"foo": "bar"},
|
|
"nested2": map[string]interface{}{"l2": "ahab"},
|
|
},
|
|
"scope": "ahab",
|
|
"name": "ahab",
|
|
"boat": true,
|
|
"nested": map[string]interface{}{"foo": false, "bar": true},
|
|
},
|
|
},
|
|
),
|
|
&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "spouter"},
|
|
Values: map[string]interface{}{
|
|
"scope": "spouter",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l1": "spouter"},
|
|
},
|
|
},
|
|
},
|
|
)
|
|
|
|
vals, err := ReadValues(testCoalesceValuesYaml)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// taking a copy of the values before passing it
|
|
// to CoalesceValues as argument, so that we can
|
|
// use it for asserting later
|
|
valsCopy := make(Values, len(vals))
|
|
for key, value := range vals {
|
|
valsCopy[key] = value
|
|
}
|
|
|
|
v, err := CoalesceValues(c, vals)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
j, _ := json.MarshalIndent(v, "", " ")
|
|
t.Logf("Coalesced Values: %s", string(j))
|
|
|
|
tests := []struct {
|
|
tpl string
|
|
expect string
|
|
}{
|
|
{"{{.top}}", "yup"},
|
|
{"{{.back}}", ""},
|
|
{"{{.name}}", "moby"},
|
|
{"{{.global.name}}", "Ishmael"},
|
|
{"{{.global.subject}}", "Queequeg"},
|
|
{"{{.global.harpooner}}", "<no value>"},
|
|
{"{{.pequod.name}}", "pequod"},
|
|
{"{{.pequod.ahab.name}}", "ahab"},
|
|
{"{{.pequod.ahab.scope}}", "whale"},
|
|
{"{{.pequod.ahab.nested.foo}}", "true"},
|
|
{"{{.pequod.ahab.global.name}}", "Ishmael"},
|
|
{"{{.pequod.ahab.global.nested.foo}}", "bar"},
|
|
{"{{.pequod.ahab.global.subject}}", "Queequeg"},
|
|
{"{{.pequod.ahab.global.harpooner}}", "Tashtego"},
|
|
{"{{.pequod.global.name}}", "Ishmael"},
|
|
{"{{.pequod.global.nested.foo}}", "<no value>"},
|
|
{"{{.pequod.global.subject}}", "Queequeg"},
|
|
{"{{.spouter.global.name}}", "Ishmael"},
|
|
{"{{.spouter.global.harpooner}}", "<no value>"},
|
|
|
|
{"{{.global.nested.boat}}", "true"},
|
|
{"{{.pequod.global.nested.boat}}", "true"},
|
|
{"{{.spouter.global.nested.boat}}", "true"},
|
|
{"{{.pequod.global.nested.sail}}", "true"},
|
|
{"{{.spouter.global.nested.sail}}", "<no value>"},
|
|
|
|
{"{{.global.nested2.l0}}", "moby"},
|
|
{"{{.global.nested2.l1}}", "<no value>"},
|
|
{"{{.global.nested2.l2}}", "<no value>"},
|
|
{"{{.pequod.global.nested2.l0}}", "moby"},
|
|
{"{{.pequod.global.nested2.l1}}", "pequod"},
|
|
{"{{.pequod.global.nested2.l2}}", "<no value>"},
|
|
{"{{.pequod.ahab.global.nested2.l0}}", "moby"},
|
|
{"{{.pequod.ahab.global.nested2.l1}}", "pequod"},
|
|
{"{{.pequod.ahab.global.nested2.l2}}", "ahab"},
|
|
{"{{.spouter.global.nested2.l0}}", "moby"},
|
|
{"{{.spouter.global.nested2.l1}}", "spouter"},
|
|
{"{{.spouter.global.nested2.l2}}", "<no value>"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
if o, err := ttpl(tt.tpl, v); err != nil || o != tt.expect {
|
|
t.Errorf("Expected %q to expand to %q, got %q", tt.tpl, tt.expect, o)
|
|
}
|
|
}
|
|
|
|
nullKeys := []string{"bottom", "right", "left", "front"}
|
|
for _, nullKey := range nullKeys {
|
|
if _, ok := v[nullKey]; ok {
|
|
t.Errorf("Expected key %q to be removed, still present", nullKey)
|
|
}
|
|
}
|
|
|
|
if _, ok := v["nested"].(map[string]interface{})["boat"]; ok {
|
|
t.Error("Expected nested boat key to be removed, still present")
|
|
}
|
|
|
|
subchart := v["pequod"].(map[string]interface{})["ahab"].(map[string]interface{})
|
|
if _, ok := subchart["boat"]; ok {
|
|
t.Error("Expected subchart boat key to be removed, still present")
|
|
}
|
|
|
|
if _, ok := subchart["nested"].(map[string]interface{})["bar"]; ok {
|
|
t.Error("Expected subchart nested bar key to be removed, still present")
|
|
}
|
|
|
|
// CoalesceValues should not mutate the passed arguments
|
|
is.Equal(valsCopy, vals)
|
|
}
|
|
|
|
func TestMergeValues(t *testing.T) {
|
|
is := assert.New(t)
|
|
|
|
c := withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "moby"},
|
|
Values: map[string]interface{}{
|
|
"back": "exists",
|
|
"bottom": "exists",
|
|
"front": "exists",
|
|
"left": "exists",
|
|
"name": "moby",
|
|
"nested": map[string]interface{}{"boat": true},
|
|
"override": "bad",
|
|
"right": "exists",
|
|
"scope": "moby",
|
|
"top": "nope",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l0": "moby"},
|
|
},
|
|
},
|
|
},
|
|
withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "pequod"},
|
|
Values: map[string]interface{}{
|
|
"name": "pequod",
|
|
"scope": "pequod",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l1": "pequod"},
|
|
},
|
|
},
|
|
},
|
|
&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "ahab"},
|
|
Values: map[string]interface{}{
|
|
"global": map[string]interface{}{
|
|
"nested": map[string]interface{}{"foo": "bar"},
|
|
"nested2": map[string]interface{}{"l2": "ahab"},
|
|
},
|
|
"scope": "ahab",
|
|
"name": "ahab",
|
|
"boat": true,
|
|
"nested": map[string]interface{}{"foo": false, "bar": true},
|
|
},
|
|
},
|
|
),
|
|
&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "spouter"},
|
|
Values: map[string]interface{}{
|
|
"scope": "spouter",
|
|
"global": map[string]interface{}{
|
|
"nested2": map[string]interface{}{"l1": "spouter"},
|
|
},
|
|
},
|
|
},
|
|
)
|
|
|
|
vals, err := ReadValues(testCoalesceValuesYaml)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// taking a copy of the values before passing it
|
|
// to MergeValues as argument, so that we can
|
|
// use it for asserting later
|
|
valsCopy := make(Values, len(vals))
|
|
for key, value := range vals {
|
|
valsCopy[key] = value
|
|
}
|
|
|
|
v, err := MergeValues(c, vals)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
j, _ := json.MarshalIndent(v, "", " ")
|
|
t.Logf("Coalesced Values: %s", string(j))
|
|
|
|
tests := []struct {
|
|
tpl string
|
|
expect string
|
|
}{
|
|
{"{{.top}}", "yup"},
|
|
{"{{.back}}", ""},
|
|
{"{{.name}}", "moby"},
|
|
{"{{.global.name}}", "Ishmael"},
|
|
{"{{.global.subject}}", "Queequeg"},
|
|
{"{{.global.harpooner}}", "<no value>"},
|
|
{"{{.pequod.name}}", "pequod"},
|
|
{"{{.pequod.ahab.name}}", "ahab"},
|
|
{"{{.pequod.ahab.scope}}", "whale"},
|
|
{"{{.pequod.ahab.nested.foo}}", "true"},
|
|
{"{{.pequod.ahab.global.name}}", "Ishmael"},
|
|
{"{{.pequod.ahab.global.nested.foo}}", "bar"},
|
|
{"{{.pequod.ahab.global.subject}}", "Queequeg"},
|
|
{"{{.pequod.ahab.global.harpooner}}", "Tashtego"},
|
|
{"{{.pequod.global.name}}", "Ishmael"},
|
|
{"{{.pequod.global.nested.foo}}", "<no value>"},
|
|
{"{{.pequod.global.subject}}", "Queequeg"},
|
|
{"{{.spouter.global.name}}", "Ishmael"},
|
|
{"{{.spouter.global.harpooner}}", "<no value>"},
|
|
|
|
{"{{.global.nested.boat}}", "true"},
|
|
{"{{.pequod.global.nested.boat}}", "true"},
|
|
{"{{.spouter.global.nested.boat}}", "true"},
|
|
{"{{.pequod.global.nested.sail}}", "true"},
|
|
{"{{.spouter.global.nested.sail}}", "<no value>"},
|
|
|
|
{"{{.global.nested2.l0}}", "moby"},
|
|
{"{{.global.nested2.l1}}", "<no value>"},
|
|
{"{{.global.nested2.l2}}", "<no value>"},
|
|
{"{{.pequod.global.nested2.l0}}", "moby"},
|
|
{"{{.pequod.global.nested2.l1}}", "pequod"},
|
|
{"{{.pequod.global.nested2.l2}}", "<no value>"},
|
|
{"{{.pequod.ahab.global.nested2.l0}}", "moby"},
|
|
{"{{.pequod.ahab.global.nested2.l1}}", "pequod"},
|
|
{"{{.pequod.ahab.global.nested2.l2}}", "ahab"},
|
|
{"{{.spouter.global.nested2.l0}}", "moby"},
|
|
{"{{.spouter.global.nested2.l1}}", "spouter"},
|
|
{"{{.spouter.global.nested2.l2}}", "<no value>"},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
if o, err := ttpl(tt.tpl, v); err != nil || o != tt.expect {
|
|
t.Errorf("Expected %q to expand to %q, got %q", tt.tpl, tt.expect, o)
|
|
}
|
|
}
|
|
|
|
// nullKeys is different from coalescing. Here the null/nil values are not
|
|
// removed.
|
|
nullKeys := []string{"bottom", "right", "left", "front"}
|
|
for _, nullKey := range nullKeys {
|
|
if vv, ok := v[nullKey]; !ok {
|
|
t.Errorf("Expected key %q to be present but it was removed", nullKey)
|
|
} else if vv != nil {
|
|
t.Errorf("Expected key %q to be null but it has a value of %v", nullKey, vv)
|
|
}
|
|
}
|
|
|
|
if _, ok := v["nested"].(map[string]interface{})["boat"]; !ok {
|
|
t.Error("Expected nested boat key to be present but it was removed")
|
|
}
|
|
|
|
subchart := v["pequod"].(map[string]interface{})["ahab"].(map[string]interface{})
|
|
if _, ok := subchart["boat"]; !ok {
|
|
t.Error("Expected subchart boat key to be present but it was removed")
|
|
}
|
|
|
|
if _, ok := subchart["nested"].(map[string]interface{})["bar"]; !ok {
|
|
t.Error("Expected subchart nested bar key to be present but it was removed")
|
|
}
|
|
|
|
// CoalesceValues should not mutate the passed arguments
|
|
is.Equal(valsCopy, vals)
|
|
}
|
|
|
|
func TestCoalesceTables(t *testing.T) {
|
|
dst := map[string]interface{}{
|
|
"name": "Ishmael",
|
|
"address": map[string]interface{}{
|
|
"street": "123 Spouter Inn Ct.",
|
|
"city": "Nantucket",
|
|
"country": nil,
|
|
},
|
|
"details": map[string]interface{}{
|
|
"friends": []string{"Tashtego"},
|
|
},
|
|
"boat": "pequod",
|
|
"hole": nil,
|
|
}
|
|
src := map[string]interface{}{
|
|
"occupation": "whaler",
|
|
"address": map[string]interface{}{
|
|
"state": "MA",
|
|
"street": "234 Spouter Inn Ct.",
|
|
"country": "US",
|
|
},
|
|
"details": "empty",
|
|
"boat": map[string]interface{}{
|
|
"mast": true,
|
|
},
|
|
"hole": "black",
|
|
}
|
|
|
|
// What we expect is that anything in dst overrides anything in src, but that
|
|
// otherwise the values are coalesced.
|
|
CoalesceTables(dst, src)
|
|
|
|
if dst["name"] != "Ishmael" {
|
|
t.Errorf("Unexpected name: %s", dst["name"])
|
|
}
|
|
if dst["occupation"] != "whaler" {
|
|
t.Errorf("Unexpected occupation: %s", dst["occupation"])
|
|
}
|
|
|
|
addr, ok := dst["address"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatal("Address went away.")
|
|
}
|
|
|
|
if addr["street"].(string) != "123 Spouter Inn Ct." {
|
|
t.Errorf("Unexpected address: %v", addr["street"])
|
|
}
|
|
|
|
if addr["city"].(string) != "Nantucket" {
|
|
t.Errorf("Unexpected city: %v", addr["city"])
|
|
}
|
|
|
|
if addr["state"].(string) != "MA" {
|
|
t.Errorf("Unexpected state: %v", addr["state"])
|
|
}
|
|
|
|
if _, ok = addr["country"]; ok {
|
|
t.Error("The country is not left out.")
|
|
}
|
|
|
|
if det, ok := dst["details"].(map[string]interface{}); !ok {
|
|
t.Fatalf("Details is the wrong type: %v", dst["details"])
|
|
} else if _, ok := det["friends"]; !ok {
|
|
t.Error("Could not find your friends. Maybe you don't have any. :-(")
|
|
}
|
|
|
|
if dst["boat"].(string) != "pequod" {
|
|
t.Errorf("Expected boat string, got %v", dst["boat"])
|
|
}
|
|
|
|
if _, ok = dst["hole"]; ok {
|
|
t.Error("The hole still exists.")
|
|
}
|
|
|
|
dst2 := map[string]interface{}{
|
|
"name": "Ishmael",
|
|
"address": map[string]interface{}{
|
|
"street": "123 Spouter Inn Ct.",
|
|
"city": "Nantucket",
|
|
"country": "US",
|
|
},
|
|
"details": map[string]interface{}{
|
|
"friends": []string{"Tashtego"},
|
|
},
|
|
"boat": "pequod",
|
|
"hole": "black",
|
|
}
|
|
|
|
// What we expect is that anything in dst should have all values set,
|
|
// this happens when the --reuse-values flag is set but the chart has no modifications yet
|
|
CoalesceTables(dst2, nil)
|
|
|
|
if dst2["name"] != "Ishmael" {
|
|
t.Errorf("Unexpected name: %s", dst2["name"])
|
|
}
|
|
|
|
addr2, ok := dst2["address"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatal("Address went away.")
|
|
}
|
|
|
|
if addr2["street"].(string) != "123 Spouter Inn Ct." {
|
|
t.Errorf("Unexpected address: %v", addr2["street"])
|
|
}
|
|
|
|
if addr2["city"].(string) != "Nantucket" {
|
|
t.Errorf("Unexpected city: %v", addr2["city"])
|
|
}
|
|
|
|
if addr2["country"].(string) != "US" {
|
|
t.Errorf("Unexpected Country: %v", addr2["country"])
|
|
}
|
|
|
|
if det2, ok := dst2["details"].(map[string]interface{}); !ok {
|
|
t.Fatalf("Details is the wrong type: %v", dst2["details"])
|
|
} else if _, ok := det2["friends"]; !ok {
|
|
t.Error("Could not find your friends. Maybe you don't have any. :-(")
|
|
}
|
|
|
|
if dst2["boat"].(string) != "pequod" {
|
|
t.Errorf("Expected boat string, got %v", dst2["boat"])
|
|
}
|
|
|
|
if dst2["hole"].(string) != "black" {
|
|
t.Errorf("Expected hole string, got %v", dst2["boat"])
|
|
}
|
|
}
|
|
|
|
func TestMergeTables(t *testing.T) {
|
|
dst := map[string]interface{}{
|
|
"name": "Ishmael",
|
|
"address": map[string]interface{}{
|
|
"street": "123 Spouter Inn Ct.",
|
|
"city": "Nantucket",
|
|
"country": nil,
|
|
},
|
|
"details": map[string]interface{}{
|
|
"friends": []string{"Tashtego"},
|
|
},
|
|
"boat": "pequod",
|
|
"hole": nil,
|
|
}
|
|
src := map[string]interface{}{
|
|
"occupation": "whaler",
|
|
"address": map[string]interface{}{
|
|
"state": "MA",
|
|
"street": "234 Spouter Inn Ct.",
|
|
"country": "US",
|
|
},
|
|
"details": "empty",
|
|
"boat": map[string]interface{}{
|
|
"mast": true,
|
|
},
|
|
"hole": "black",
|
|
}
|
|
|
|
// What we expect is that anything in dst overrides anything in src, but that
|
|
// otherwise the values are coalesced.
|
|
MergeTables(dst, src)
|
|
|
|
if dst["name"] != "Ishmael" {
|
|
t.Errorf("Unexpected name: %s", dst["name"])
|
|
}
|
|
if dst["occupation"] != "whaler" {
|
|
t.Errorf("Unexpected occupation: %s", dst["occupation"])
|
|
}
|
|
|
|
addr, ok := dst["address"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatal("Address went away.")
|
|
}
|
|
|
|
if addr["street"].(string) != "123 Spouter Inn Ct." {
|
|
t.Errorf("Unexpected address: %v", addr["street"])
|
|
}
|
|
|
|
if addr["city"].(string) != "Nantucket" {
|
|
t.Errorf("Unexpected city: %v", addr["city"])
|
|
}
|
|
|
|
if addr["state"].(string) != "MA" {
|
|
t.Errorf("Unexpected state: %v", addr["state"])
|
|
}
|
|
|
|
// This is one test that is different from CoalesceTables. Because country
|
|
// is a nil value and it's not removed it's still present.
|
|
if _, ok = addr["country"]; !ok {
|
|
t.Error("The country is left out.")
|
|
}
|
|
|
|
if det, ok := dst["details"].(map[string]interface{}); !ok {
|
|
t.Fatalf("Details is the wrong type: %v", dst["details"])
|
|
} else if _, ok := det["friends"]; !ok {
|
|
t.Error("Could not find your friends. Maybe you don't have any. :-(")
|
|
}
|
|
|
|
if dst["boat"].(string) != "pequod" {
|
|
t.Errorf("Expected boat string, got %v", dst["boat"])
|
|
}
|
|
|
|
// This is one test that is different from CoalesceTables. Because hole
|
|
// is a nil value and it's not removed it's still present.
|
|
if _, ok = dst["hole"]; !ok {
|
|
t.Error("The hole no longer exists.")
|
|
}
|
|
|
|
dst2 := map[string]interface{}{
|
|
"name": "Ishmael",
|
|
"address": map[string]interface{}{
|
|
"street": "123 Spouter Inn Ct.",
|
|
"city": "Nantucket",
|
|
"country": "US",
|
|
},
|
|
"details": map[string]interface{}{
|
|
"friends": []string{"Tashtego"},
|
|
},
|
|
"boat": "pequod",
|
|
"hole": "black",
|
|
"nilval": nil,
|
|
}
|
|
|
|
// What we expect is that anything in dst should have all values set,
|
|
// this happens when the --reuse-values flag is set but the chart has no modifications yet
|
|
MergeTables(dst2, nil)
|
|
|
|
if dst2["name"] != "Ishmael" {
|
|
t.Errorf("Unexpected name: %s", dst2["name"])
|
|
}
|
|
|
|
addr2, ok := dst2["address"].(map[string]interface{})
|
|
if !ok {
|
|
t.Fatal("Address went away.")
|
|
}
|
|
|
|
if addr2["street"].(string) != "123 Spouter Inn Ct." {
|
|
t.Errorf("Unexpected address: %v", addr2["street"])
|
|
}
|
|
|
|
if addr2["city"].(string) != "Nantucket" {
|
|
t.Errorf("Unexpected city: %v", addr2["city"])
|
|
}
|
|
|
|
if addr2["country"].(string) != "US" {
|
|
t.Errorf("Unexpected Country: %v", addr2["country"])
|
|
}
|
|
|
|
if det2, ok := dst2["details"].(map[string]interface{}); !ok {
|
|
t.Fatalf("Details is the wrong type: %v", dst2["details"])
|
|
} else if _, ok := det2["friends"]; !ok {
|
|
t.Error("Could not find your friends. Maybe you don't have any. :-(")
|
|
}
|
|
|
|
if dst2["boat"].(string) != "pequod" {
|
|
t.Errorf("Expected boat string, got %v", dst2["boat"])
|
|
}
|
|
|
|
if dst2["hole"].(string) != "black" {
|
|
t.Errorf("Expected hole string, got %v", dst2["boat"])
|
|
}
|
|
|
|
if dst2["nilval"] != nil {
|
|
t.Error("Expected nilvalue to have nil value but it does not")
|
|
}
|
|
}
|
|
|
|
func TestCoalesceValuesWarnings(t *testing.T) {
|
|
|
|
c := withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "level1"},
|
|
Values: map[string]interface{}{
|
|
"name": "moby",
|
|
},
|
|
},
|
|
withDeps(&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "level2"},
|
|
Values: map[string]interface{}{
|
|
"name": "pequod",
|
|
},
|
|
},
|
|
&chart.Chart{
|
|
Metadata: &chart.Metadata{Name: "level3"},
|
|
Values: map[string]interface{}{
|
|
"name": "ahab",
|
|
"boat": true,
|
|
"spear": map[string]interface{}{
|
|
"tip": true,
|
|
"sail": map[string]interface{}{
|
|
"cotton": true,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
),
|
|
)
|
|
|
|
vals := map[string]interface{}{
|
|
"level2": map[string]interface{}{
|
|
"level3": map[string]interface{}{
|
|
"boat": map[string]interface{}{"mast": true},
|
|
"spear": map[string]interface{}{
|
|
"tip": map[string]interface{}{
|
|
"sharp": true,
|
|
},
|
|
"sail": true,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
warnings := make([]string, 0)
|
|
printf := func(format string, v ...interface{}) {
|
|
t.Logf(format, v...)
|
|
warnings = append(warnings, fmt.Sprintf(format, v...))
|
|
}
|
|
|
|
_, err := coalesce(printf, c, vals, "", false)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
t.Logf("vals: %v", vals)
|
|
assert.Contains(t, warnings, "warning: skipped value for level1.level2.level3.boat: Not a table.")
|
|
assert.Contains(t, warnings, "warning: destination for level1.level2.level3.spear.tip is a table. Ignoring non-table value (true)")
|
|
assert.Contains(t, warnings, "warning: cannot overwrite table with non table for level1.level2.level3.spear.sail (map[cotton:true])")
|
|
|
|
}
|
|
|
|
func TestConcatPrefix(t *testing.T) {
|
|
assert.Equal(t, "b", concatPrefix("", "b"))
|
|
assert.Equal(t, "a.b", concatPrefix("a", "b"))
|
|
}
|