mirror of
https://github.com/helm/helm.git
synced 2026-04-07 10:05:01 -04:00
3637996dcd
This is a port of #5165 and the small refactor in #5610. This is the issue where carefully crafted paths can reach outside of the intended chart directory Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
121 lines
2.6 KiB
Go
121 lines
2.6 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package chartutil
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestExpand(t *testing.T) {
|
|
dest, err := ioutil.TempDir("", "helm-testing-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dest)
|
|
|
|
reader, err := os.Open("testdata/frobnitz-1.2.3.tgz")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if err := Expand(dest, reader); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
expectedChartPath := filepath.Join(dest, "frobnitz")
|
|
fi, err := os.Stat(expectedChartPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !fi.IsDir() {
|
|
t.Fatalf("expected a chart directory at %s", expectedChartPath)
|
|
}
|
|
|
|
dir, err := os.Open(expectedChartPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
fis, err := dir.Readdir(0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
expectLen := 11
|
|
if len(fis) != expectLen {
|
|
t.Errorf("Expected %d files, but got %d", expectLen, len(fis))
|
|
}
|
|
|
|
for _, fi := range fis {
|
|
expect, err := os.Stat(filepath.Join("testdata", "frobnitz", fi.Name()))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if fi.Size() != expect.Size() {
|
|
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExpandFile(t *testing.T) {
|
|
dest, err := ioutil.TempDir("", "helm-testing-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dest)
|
|
|
|
if err := ExpandFile(dest, "testdata/frobnitz-1.2.3.tgz"); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
expectedChartPath := filepath.Join(dest, "frobnitz")
|
|
fi, err := os.Stat(expectedChartPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !fi.IsDir() {
|
|
t.Fatalf("expected a chart directory at %s", expectedChartPath)
|
|
}
|
|
|
|
dir, err := os.Open(expectedChartPath)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
fis, err := dir.Readdir(0)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
expectLen := 11
|
|
if len(fis) != expectLen {
|
|
t.Errorf("Expected %d files, but got %d", expectLen, len(fis))
|
|
}
|
|
|
|
for _, fi := range fis {
|
|
expect, err := os.Stat(filepath.Join("testdata", "frobnitz", fi.Name()))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if fi.Size() != expect.Size() {
|
|
t.Errorf("Expected %s to have size %d, got %d", fi.Name(), expect.Size(), fi.Size())
|
|
}
|
|
}
|
|
}
|