mirror of
https://github.com/helm/helm.git
synced 2026-05-28 04:35:48 -04:00
2ceebffc77
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
116 lines
2.4 KiB
Go
116 lines
2.4 KiB
Go
/*
|
|
Copyright The Helm Authors.
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package repotest
|
|
|
|
import (
|
|
"io"
|
|
"net/http"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"sigs.k8s.io/yaml"
|
|
|
|
"helm.sh/helm/v3/internal/test/ensure"
|
|
"helm.sh/helm/v3/pkg/repo"
|
|
)
|
|
|
|
// Young'n, in these here parts, we test our tests.
|
|
|
|
func TestServer(t *testing.T) {
|
|
ensure.HelmHome(t)
|
|
|
|
rootDir := t.TempDir()
|
|
|
|
srv := NewServer(rootDir)
|
|
defer srv.Stop()
|
|
|
|
c, err := srv.CopyCharts("testdata/*.tgz")
|
|
if err != nil {
|
|
// Some versions of Go don't correctly fire defer on Fatal.
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if len(c) != 1 {
|
|
t.Errorf("Unexpected chart count: %d", len(c))
|
|
}
|
|
|
|
if filepath.Base(c[0]) != "examplechart-0.1.0.tgz" {
|
|
t.Errorf("Unexpected chart: %s", c[0])
|
|
}
|
|
|
|
res, err := http.Get(srv.URL() + "/examplechart-0.1.0.tgz")
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if res.ContentLength < 500 {
|
|
t.Errorf("Expected at least 500 bytes of data, got %d", res.ContentLength)
|
|
}
|
|
|
|
res, err = http.Get(srv.URL() + "/index.yaml")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
data, err := io.ReadAll(res.Body)
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
m := repo.NewIndexFile()
|
|
if err := yaml.Unmarshal(data, m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if l := len(m.Entries); l != 1 {
|
|
t.Fatalf("Expected 1 entry, got %d", l)
|
|
}
|
|
|
|
expect := "examplechart"
|
|
if !m.Has(expect, "0.1.0") {
|
|
t.Errorf("missing %q", expect)
|
|
}
|
|
|
|
res, err = http.Get(srv.URL() + "/index.yaml-nosuchthing")
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if res.StatusCode != 404 {
|
|
t.Fatalf("Expected 404, got %d", res.StatusCode)
|
|
}
|
|
}
|
|
|
|
func TestNewTempServer(t *testing.T) {
|
|
ensure.HelmHome(t)
|
|
|
|
srv, err := NewTempServerWithCleanup(t, "testdata/examplechart-0.1.0.tgz")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer srv.Stop()
|
|
|
|
res, err := http.Head(srv.URL() + "/examplechart-0.1.0.tgz")
|
|
res.Body.Close()
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
if res.StatusCode != 200 {
|
|
t.Errorf("Expected 200, got %d", res.StatusCode)
|
|
}
|
|
}
|