upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-04-20 21:56:55 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
8361 commits 65 branches 249 tags 137 MiB
Commit graph

3140 commits

Author SHA1 Message Date
Jesse Simpson
f09bbb8ab8
style: consolidate for loops 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:28 -04:00
Jesse Simpson
1357db4db1
style: removed variable only used once 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:28 -04:00
Jesse Simpson
a56daca82b
style: use interface functions instead of inline logic 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:28 -04:00
Jesse Simpson
87f9e2dc45
style: create String function for TraceableError representing one chunk of a stacktrace 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:28 -04:00
Jesse Simpson
6cd0c0082a
fix: split up the multiline errors to be more vertical 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:28 -04:00
Jesse Simpson
cc477e9f79
fix: adjust test to not require external chart 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:17:26 -04:00
Jesse Simpson
14f902c245
wip: draft at making cleaner stacktraces 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-04-24 19:16:09 -04:00
George Jenkins
ecf1730689
Merge pull request #13460 from justenstall/stdlib-errors-2 
fix: replace "github.com/pkg/errors" with stdlib "errors" package
 2025-04-23 15:47:35 -07:00
Justen Stall
4905a61026
Merge branch 'main' into stdlib-errors-2 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-23 15:58:33 -04:00
Matt Farina
fcd37bcea7
Merge pull request #30783 from rpolishchuk/investigate-TestValidateChartIconPresence 
fix: chart icon presence test
 2025-04-23 20:58:14 +01:00
Robert Sirchia
d9bc0a948c
Merge pull request #30777 from ryanhockstad/merge-fix 
fix: null merge. closes #30587
 2025-04-23 15:07:54 -04:00
Scott Rigby
a911aa2112
Merge pull request #9175 from dastrobu/copy-dependencies-on-aliasing 
fix: copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies
 2025-04-23 14:40:51 -04:00
Daniel Strobusch
b183eccfc4
copy dependency metadata on aliasing to avoid sharing imported values 
imported values are stored in dependency objects, which breaks if a chart dependency is shared among multiple aliases.
By copying the dependency objects in the metadata values can be imported correctly.

Supersedes #10174

Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
 2025-04-23 11:32:45 +02:00
Daniel Strobusch
df7befd208
copy dependencies on aliasing to avoid sharing chart references on multiply aliased dependencies 
Dependencies keep a reference on their parent chart, which breaks if a chart reference is shared among multiple aliases.
By copying the dependencies, parent information can be set correctly to render the templates as expected later on.

Note that this change will make ChartFullPath return a different path for sub-subcharts. It will contain the alias names instead of the path to the chart files which makes it consistent with paths to templates on the subchart level.

Closes #9150

Signed-off-by: Daniel Strobusch <1847260+dastrobu@users.noreply.github.com>
 2025-04-23 11:16:05 +02:00
Stephen Murray
1682895636 ref(helm): Export Chart Not Found error 
Closes #30746

Signed-off-by: Stephen Murray <stephenmurrayengineer@gmail.com>
 2025-04-22 20:29:38 +01:00
Rostyslav Polishchuk
1c8d1e375f fix: chart icon presence test 
The `TestValidateChartIconPresence` test fails when run after
`TestValidateChartIconURL` as they both are using a global
variable `badChart.Icon`

```
: go test -v -test.shuffle 1 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 1
=== RUN   TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
=== RUN   TestValidateChartIconPresence
    chartfile_test.go:171: validateChartIconPresence to return a linter error, got no error
--- FAIL: TestValidateChartIconPresence (0.00s)
FAIL
FAIL    helm.sh/helm/v4/pkg/lint/rules  0.051s
FAIL

: go test -v -test.shuffle 2 -run '^(TestValidateChartIconPresence|TestValidateChartIconURL)$' ./pkg/lint/rules/
-test.shuffle 2
=== RUN   TestValidateChartIconPresence
--- PASS: TestValidateChartIconPresence (0.00s)
=== RUN   TestValidateChartIconURL
--- PASS: TestValidateChartIconURL (0.00s)
PASS
ok      helm.sh/helm/v4/pkg/lint/rules  0.050s
```

This commit:

1. Remove dependency on global variable
2. Explicitly set the state of the test object.

Signed-off-by: Rostyslav Polishchuk <rostyslavp@google.com>
 2025-04-22 18:56:13 +00:00
Justen Stall
fc6c5e5edb
remove WaitAndGetCompletedPodPhase function 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 17:19:48 -04:00
Justen Stall
73545f9a3e
one more test output 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 16:08:21 -04:00
Justen Stall
4a6092bd6c
update another test output 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 16:04:28 -04:00
Justen Stall
7a316c8d51
update expected error message in install test 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 15:57:54 -04:00
Matthieu MOREL
d3eeb2c942 chore: remove github.com/hashicorp/go-multierror dependency 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
 2025-04-21 19:27:15 +02:00
Justen Stall
3877ec9049
fix golangci-lint issues 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 12:44:40 -04:00
Justen Stall
065e2eb3eb
updates after merge conflict resolution 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 12:17:50 -04:00
Justen Stall
280a9ddbdb
Merge branch 'main' into stdlib-errors-2 
Signed-off-by: Justen Stall <39888103+justenstall@users.noreply.github.com>
 2025-04-21 12:13:10 -04:00
Scott Rigby
eb6e240cfe
Merge pull request #30734 from ipaqsa/feature/add-custom-template-funcs 
feat(pkg/engine): add support for custom template funcs
 2025-04-21 11:13:12 -04:00
Scott Rigby
8255300280
Merge pull request #12382 from edbmiller/ed-dot-miller/parse-chartfile-yaml-strictly 
fix(pkg/lint): unmarshals Chart.yaml strictly
 2025-04-20 15:35:51 -04:00
Ryan Hockstad
c1175a4106 fix null merge 
Signed-off-by: Ryan Hockstad <ryanhockstad@gmail.com>
 2025-04-20 15:29:19 -04:00
Edward Miller
e414695a5b fix 
Signed-off-by: Edward Miller <edmiller287@gmail.com>
 2025-04-19 13:41:43 +01:00
Benoit Tigeot
e2461de3c2
Fix test with toml bump 
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-04-19 00:48:23 +02:00
Matt Farina
a842140ef6
Merge pull request #13578 from gjenkins8/rm_chart_repo_load_func 
refactor: Remove ChartRepository `[]ChartPaths`
 2025-04-18 20:43:52 +01:00
Edward Miller
629780a34a fix: reapply error message fix 
Signed-off-by: Edward Miller <edmiller287@gmail.com>
 2025-04-18 19:18:55 +01:00
Edward Miller
9d43f70643 Update error message 
Co-authored-by: Andrew Block <andy.block@gmail.com>
Signed-off-by: Edward Miller <55854159+edbmiller@users.noreply.github.com>
 2025-04-18 19:13:40 +01:00
Edward Miller
14a468f24d Add chartutil.StrictLoadChartfile for strict (WARNING-level) lint 
Signed-off-by: Edward Miller <edmiller287@gmail.com>
 2025-04-18 19:13:40 +01:00
Edward Miller
00f8561ad4 fix(pkg/lint): unmarshals Chart.yaml strictly 
When "helm lint" is run, it now errors on invalid chartfiles,
e.g. those with duplicate keys

Closes #12381

Signed-off-by: Edward Miller <edmiller287@gmail.com>
 2025-04-18 19:13:40 +01:00
wangcundashang
7bb0c85441 chore: fix function name in comment 
Signed-off-by: wangcundashang <wangcundashang@qq.com>
 2025-04-18 19:11:41 +08:00
Stepan Paksashvili
b54349d9b2 fix(pkg/engine): allow to override all functions 
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
 2025-04-18 10:29:56 +03:00
Stepan Paksashvili
5c2f89307d feat(pkg/engine): and custom funcs to action config 
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
 2025-04-18 10:29:56 +03:00
Stepan Paksashvili
8982b57e5e feat(pkg/engine): and custom funcs overriding test 
Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
 2025-04-18 10:29:56 +03:00
Stepan Paksashvili
9073bcf53e feat(pkg/engine): add support for custom template funcs 
Enhances the template engine and action config to allow users to inject custom template functions via an action config when using Helm as a library.

Closes #30733

Signed-off-by: Stepan Paksashvili <stepan.paksashvili@flant.com>
 2025-04-18 10:29:56 +03:00
Scott Rigby
599fad1864
Merge pull request #30697 from p-se/fix-take-ownership 
Fix --take-ownership for custom resources - closes #30622
 2025-04-17 11:54:11 -04:00
Evans Mungai
1f5605a405
fix formatting errors 
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
 2025-04-17 15:33:21 +01:00
Benoit Tigeot
d33e2896f0
Prevent failures with method signatures on hooks 
changes on wait strategy. This PR try to fix linting and tests.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-04-17 12:37:37 +02:00
Scott Rigby
e397f44840
Merge pull request #30673 from nvanthao/process-all-hook-deletions-on-failure 
fix: Process all hook deletions on failure
 2025-04-16 17:21:28 -04:00
Matt Farina
01590a59b2
Merge pull request #30760 from robertsirc/add-debuging-to-jsonschema 
adding slog debug to a few points
 2025-04-16 21:10:22 +01:00
Robert Sirchia
8733103743
Merge pull request #30718 from klihub/fixes/package/multiple-charts-single-passwd-from-stdin 
Allow signing multiple charts with a single passphrase from stdin.
 2025-04-16 16:07:44 -04:00
Robert Sirchia
da096e1b7a
Merge pull request #30752 from benoittgt/bump-golangci-lint-action 
Bump golangci lint to last major version and fix static-check errors
 2025-04-16 15:50:55 -04:00
Robert Sirchia
ef0361de21
fixing as per review 
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
 2025-04-16 15:26:44 -04:00
Robert Sirchia
9b9ff12c6d
adding slog debug to a few points 
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
 2025-04-16 11:36:05 -04:00
Krisztian Litkey
3102c28804
fix: allow signing multiple charts with passphrase from stdin. 
Cache the signing key passphrase. When signing multiple charts
with the passphrase from stdin, this allows signing all charts
instead of all but the first failing with an error about stdin
already having been closed.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
 2025-04-16 18:05:36 +03:00
Evans Mungai
e8e79cc4b4
Merge branch 'main' into fix-take-ownership 
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
 2025-04-15 04:46:17 -06:00