Commit graph

2330 commits

Author SHA1 Message Date
Graham Reed
ebf5e1e2af Check that .Template is passed through tpl
Signed-off-by: Graham Reed <greed@7deadly.org>
2022-10-20 16:25:36 +01:00
Graham Reed
0a6e7d95ab Make sure empty tpl values render empty.
Signed-off-by: Graham Reed <greed@7deadly.org>
2022-10-20 16:25:36 +01:00
Graham Reed
d1e9a242a7 Pick the test improvement out of PR#8371
<https://github.com/helm/helm/pull/8371>

This covers:
  - `tpl` text can `include` a `define` provided in a partial file
  - `tpl` text can `include` a `define` provided in its text
  - `tpl` text can be loaded via `.Files.Get`

Signed-off-by: Graham Reed <greed@7deadly.org>
2022-10-20 16:25:09 +01:00
Matt Farina
90a25751bd
Merge pull request #11172 from crenshaw-dev/cleanup-after-find-chart
fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (#11171)
2022-10-11 13:58:46 -04:00
Matt Farina
95140c96d6
Merge pull request #11044 from wujunwei/bug-fix-nil-dependency
add nil judge in  dependency and maintainer validation
2022-10-05 10:44:47 -04:00
Matt Farina
792450129f
Merge pull request #9824 from sathieu/fix_helm_chart_download_without_trailing_slash
Fix URL with encoded path support for ChartDownloader
2022-10-05 10:41:17 -04:00
Martin Hickey
2baf68fe2d
Merge pull request #11401 from dims/retry-for-issue-9502
Tolerate temporary errors from etcdserver
2022-10-05 12:19:26 +01:00
Matt Farina
37dd72729b
Merge pull request #11336 from mattfarina/bump-version-3.10
bump version to v3.10.0
2022-10-03 09:32:13 -04:00
Davanum Srinivas
ebc79fa807
Tolerate temporary errors from etcdserver
There are cases when the etcdserver is temporarily unavailable and the
errors that we get back from kube-apiserver reflect that error. It looks
like we bail out immediately when these errors happen currently. We
should retry until timeout is reached when this sort of errors happen.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-10-01 20:12:38 -04:00
wujunwei
4fcec24d15 update: Optimize the error message
Signed-off-by: wujunwei <wjw3323@live.com>
2022-09-24 12:56:03 +08:00
wujunwei
a7a1117327 add nil judge for dependency , maintainers validate and some testcase.
Signed-off-by: wujunwei <wjw3323@live.com>
2022-09-24 12:56:03 +08:00
Martin Hickey
ae828ce0ee Fix code style
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
2022-09-21 16:35:29 +01:00
Matt Farina
cd809f9b19
bump version to v3.10.0
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit ce66412a72)
2022-09-12 15:29:41 -04:00
CI
c1bf99c0eb Merge remote-tracking branch 'origin/main' into cleanup-after-find-chart 2022-09-06 08:32:06 -04:00
Martin Hickey
8199db309a
Merge pull request #10693 from lucadirocco/feat/--set-json
feat: add --set-json flag to set json values.
2022-08-31 21:40:19 +01:00
Matt Farina
225f8d7732 Updating index handling
Signed-off-by: Matt Farina <matt@mattfarina.com>
2022-08-17 13:42:28 -04:00
Martin Hickey
f08db5c899
Merge pull request #10834 from stan-sz/stan-sz/10285
Log error message on failed download
2022-08-12 09:57:16 +01:00
Martin Hickey
1d15ad7ea4
Merge pull request #10506 from suzaku/support-no-headers
Add support for`helm list --no-headers`
2022-08-12 09:55:31 +01:00
Martin Hickey
4cd966fdb5
Merge pull request #11214 from d-d-up/fix_special_string
fix special string in the filename
2022-08-11 09:51:38 +01:00
Matt Farina
4b18b19a5e
Merge pull request #11143 from aep/for-upstream
fixes #11142 missing array length check on release
2022-08-09 14:12:52 -04:00
d-d-up
ece46c1d3a fix special string in the filename
Signed-off-by: d-d-up <qhr6113@163.com>
2022-08-09 14:12:26 +08:00
CI
3b19ddeb56 one defer
Signed-off-by: CI <ci@argoproj.com>
2022-08-05 10:02:18 -04:00
CI
781ddba690 don't change r.CachePath
Signed-off-by: CI <ci@argoproj.com>
2022-07-29 16:12:16 -04:00
Matt Farina
b3aa0b4118
Fixing x509 test on darwin
Go passes x509 verification off to the platform and different
platforms provide different responses. The Go tests for x509
even have different test files for different platform providers
that check for different messages.

This update haldes darwins difference for x509 authority handling

Closes #11159

Signed-off-by: Matt Farina <matt@mattfarina.com>
2022-07-27 12:48:52 -04:00
CI
cd76fcd805 avoid adding new public function
Signed-off-by: CI <ci@argoproj.com>
2022-07-22 12:58:54 -04:00
CI
32a41fcfac fix tests
Signed-off-by: CI <ci@argoproj.com>
2022-07-21 12:42:56 -04:00
CI
24fa3d910d fix: clean up temp files in FindChartInAuthAndTLSAndPassRepoURL (#11171)
Signed-off-by: CI <ci@argoproj.com>
2022-07-21 12:29:14 -04:00
Arvid E. Picciani
b9f347a574 fixes #11142 missing array length check on release
Signed-off-by: Arvid E. Picciani <arvid@kraud.cloud>
2022-07-13 11:26:04 +02:00
Matthew Fisher
aa6e82bac8
fix: use go install instead of go get
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
2022-07-06 13:34:15 -07:00
yxxhero
39b0a82365 bump Go 1.18
Signed-off-by: yxxhero <aiopsclub@163.com>
2022-07-03 10:19:15 +08:00
Dominic Evans
7c74f1dd02 fix: improve logging & safety of statefulSetReady
Confirm that the current and updated revision numbers also match as part
of the readiness check. Add coverage for readiness scenarios where
StatefulSet status does not reflect the most recent generation of the
StatefulSet yet.

Also add additional logging around the sts transitions from non-ready to
ready.

Fixes: #10163

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
2022-06-28 09:48:17 +01:00
Soule BA
42a04c76a4
make token caching an opt in feature
If implemented, users have to opt in to cache a token.

Signed-off-by: Soule BA <bah.soule@gmail.com>
2022-06-27 14:23:25 +02:00
Justen Walker
687852e4fe feat(*): add flags/env for kube api tls overrides
Add a new flags and associated environment variables to override
 the TLS Settings used when constructing the Kube Client.

- `--kube-insecure-skip-tls-verify | HELM_KUBEINSECURE_SKIP_TLS_VERIFY`: if true, the kube api server's certificate will not be checked for validity. This will make your HTTPS connections insecure
- `--kube-tls-server-name | HELM_KUBETLS_SERVER_NAME`: server name to use for kube api server certificate validation. If it is not provided, the hostname used to contact the server is used

Signed-off-by: Justen Walker <justen.walker+github@gmail.com>
2022-05-19 23:32:00 -04:00
Igor Sutton
823d929421
Add --burst-limit option for client-side throttling limit configuration (#10842)
* feat: add configuration for client-side throttling limit

Client-side throttling seems to be an issue in larger environments such as OpenShift clusters, where
it is common to have several hundreds CRDs out-of-the-box.

From this view point, it is fair that clients should be able to fine tune this accordingly should the
environment they work on evolves, which is currently not possible, and quite frustrating.

This change introduces the --default-burst-limit option to helm (and its counterpart
HELM_DEFAULT_BURST_LIMIT environment variable) to address that issue, allowing clients to properly
tune their client usage as their environment evolves.

Signed-off-by: Igor Sutton <isuttonl@redhat.com>

* chore: change DefaultBurstLimit to BurstLimit

Signed-off-by: Igor Sutton <isuttonl@redhat.com>

* chore: add HELM_BURST_LIMIT to golden file

Signed-off-by: Igor Sutton <isuttonl@redhat.com>

* chore: add burst limit tests

Signed-off-by: Igor Sutton <isuttonl@redhat.com>

* docs: add burst limit default value to documentation

Signed-off-by: Igor Sutton <isuttonl@redhat.com>

* refactor: change burst limit default value to 100 per review instructions

Signed-off-by: Igor Sutton <isuttonl@redhat.com>
2022-05-17 20:00:57 +02:00
Matthew Fisher
2ae4937e42
Merge pull request #10762 from yxxhero/fix_registry_config_issue
fix --registry-config issue
2022-05-13 10:08:04 -07:00
Matthew Fisher
e54e24cc90
Merge pull request #10852 from IamMayankThakur/main
Fixed helm uninstall not deleting the resource.
2022-05-13 10:05:52 -07:00
Matt Farina
1db28a2311
bump version to v3.9.0
Signed-off-by: Matt Farina <matt.farina@suse.com>
(cherry picked from commit 7ceeda6c58)
2022-05-09 15:20:33 -04:00
Matt Farina
2cd709c4a6
Merge pull request #10106 from presztak/lint_quiet_flag
feat(*): add --quiet flag to 'helm lint'
2022-05-06 16:30:38 -04:00
Andrew Seigner
bd7c97f786 Bump k8s packages from 0.23.6 to 0.24.0
This required modifying the `kube.Factory` interface to conform to
changes in k8s' `cmdutil.Factory` interface:
fe3772890f

Signed-off-by: Andrew Seigner <andrew@sig.gy>
2022-05-04 10:58:09 +00:00
Martin Hickey
8d3f9a475d
Merge pull request #10767 from marquiz/fixes/unit-test
repo: fix repo merge unit test
2022-05-04 10:06:03 +01:00
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes
Remove AssertGoldenBytes test helper
2022-04-29 09:37:23 +01:00
Mathieu Parent
d9e5bbc09d Fix URL with encoded path support for ChartDownloader
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
2022-04-29 05:18:43 +02:00
Martin Hickey
f1b1958e68
Merge pull request #10085 from werf/fix_no_deployed_releases_on_history_limit_hit
"... has no deployed releases" error when release history contains only failed releases and history limit reached
2022-04-28 13:41:46 +01:00
Martin Hickey
511df9e710
Merge pull request #10201 from SgtCoDFish/signerrcheck
Add more error checks during the signing process
2022-04-28 13:37:36 +01:00
Matthew Fisher
49819b4ef7
Merge pull request #10861 from bacongobbler/gobuild
replace +build with go:build
2022-04-15 06:28:13 -07:00
Martin Hickey
a368bde6c8
Merge pull request #10850 from greed42/install-helm-version
Populate Capabilities.HelmVersion during install
2022-04-15 09:29:59 +01:00
Matthew Fisher
2878cc8079
replace +build with go:build
go:build is the new conditional compilation directive used to specify build constraints. It was introduced in Go 1.17. It is meant to replace the old +build directives.

Now that go.mod points to Go 1.17 we no longer need to support both
build flags.

Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
2022-04-14 07:56:31 -07:00
Matt Farina
4d2e21e860
Merge pull request #10832 from true-north-engineering/main
Fixing downloader plugin error handling
2022-04-12 12:46:04 -04:00
Matt Farina
3fdb7cac01
Merge pull request #10110 from zegerius/main
Fix value precedence
2022-04-12 11:08:33 -04:00
Mayank Thakur
fe00c9296d Fixed helm uninstall not deleting the resource.
* Added `nil` check for returned err.
  * Return in case of `err` when deleting the release

Signed-off-by: Mayank Thakur <thakurmayank88@gmail.com>
2022-04-12 12:55:47 +05:30