upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-04-26 16:47:26 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
7920 commits 65 branches 249 tags 141 MiB
Commit graph

2830 commits

Author SHA1 Message Date
Terry Howe
b52bb41484
fix: add debug logging to oci transport 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
 2025-06-06 12:11:14 -06:00
Terry Howe
733f94c86a fix: legacy docker support broken for login 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-05-30 15:43:44 -04:00
Robert Sirchia
9d56978f65
Merge pull request #30938 from TerryHowe/backport-fix-plugin-install-no-internet 
fix: backport plugin installer test with no Internet
 2025-05-30 14:59:36 -04:00
Terry Howe
fc36041702 fix: plugin installer test with no Internet 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-05-30 06:56:02 -04:00
Scott Rigby
62759a819e
Merge pull request #30916 from jessesimpson36/v3-remove-registry-login-url-with-tests 
test: add functional tests for "Fix 3.18.0 regression: registry login with scheme"
 2025-05-29 11:29:56 -04:00
Matt Farina
cfe8cef46f
Handle an empty registry config file. 
In the move to oras v2, an existing but empty registry config file
became an uncaught error. A missing file caused no error. This
change catches the error and works around it so that Helm can
continue to be fault tolerant to this issue.

Signed-off-by: Matt Farina <matt.farina@suse.com>
 2025-05-29 08:16:51 -04:00
Benoit Tigeot
c33215d765 Prevent fetching newReference again as we have in calling method 
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-05-23 14:25:56 -06:00
Benoit Tigeot
f552b67230 Prevent failure when resolving version tags in oras memory store 
- The newReference() function transforms version tags by replacing + with _ for OCI compatibility
- But the code was using the original ref (with +) for TagBytes()
- Then it tries to find the tagged reference using parsedRef.String() (with _)
- This mismatch causes the Resolve method to fail with "not found"
- By using parsedRef.String() consistently in both places, the references will match and the lookup will succeed.

I extracted the TagBytes function to improve testability.
Push() includes several external calls that are hard to mock,
so isolating this logic makes testing more manageable.

Close: #30881
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-05-23 14:18:02 -06:00
Matt Farina
806d59750a
Merge pull request #30902 from brandtkeller/30890_prov_mediatype_allow 
fix(client): allow layer selection permissive
 2025-05-23 16:12:03 -04:00
Scott Rigby
e37962522c
Merge pull request #30887 from scottrigby/v3-remove-registry-login-url 
Fix 3.18.0 regression: registry login with scheme
 2025-05-23 00:13:29 -04:00
Brandt Keller
a18a52e898
fix(client): skipnode utilization for PreCopy 
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
 2025-05-22 20:06:11 -07:00
Jesse Simpson
fedf5024d6
test: Skip instead of returning early. looks more intentional 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-05-22 18:49:33 -04:00
Jesse Simpson
fe512bae43
test: tests repo stripping functionality 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-05-22 16:49:10 -04:00
Jesse Simpson
099a9e18f3
test: include tests for Login based on different protocol prefixes 
Signed-off-by: Jesse Simpson <jesse.simpson36@gmail.com>
 2025-05-22 16:35:35 -04:00
Brandt Keller
b07ab77da3
fix(client): layers now returns manifest - remove duplicate from descriptors 
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
 2025-05-22 20:27:46 +00:00
Brandt Keller
c225c124ac
fix(client): return nil on non-allowed media types 
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
 2025-05-22 20:11:40 +00:00
Scott Rigby
c0f3ace52d
Fix 3.18.0 regression: registry login with scheme 
Helm 3.18.0 released an upgrade of ORAS from v1 to v2.

ORAS v2 correctly does not accept http/https scheme for registry login, while
ORAS v1 previously did. Even if v1 should not have, we want to preserve
backwards compatibility for Helm 3 users who pass the scheme.

This will be removed in Helm 4, where registry login will not accept http/https
scheme.

Co-authored-by: Andrew Block <andy.block@gmail.com>
Co-authored-by: Terry Howe <terrylhowe@gmail.com>

Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-05-22 15:07:47 -04:00
Robert Sirchia
f147277a59
Merge pull request #30885 from helm/revert-13534-dev-v3-12987 
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]"
 2025-05-21 15:19:08 -04:00
Benoit Tigeot
dce60adb51
Update pkg/plugin/plugin.go 
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
 2025-05-21 09:45:45 +02:00
Benoit Tigeot
cda0865d64
Update pkg/plugin/plugin.go 
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Benoit Tigeot <benoittgt@users.noreply.github.com>
 2025-05-21 09:45:40 +02:00
Benoit Tigeot
5d9d9a0fb8
Wait for Helm v4 before raising when platformCommand and Command are set 
same for `PlatformHooks` and `hooks`.

When backporting a feature for Helm v3 we forgot to mark as deprecation
validations that will enforced in v4.

See (search for "Remove in Helm 4."):
- https://github.com/helm/helm/pull/13592/files#diff-fc137d62147eb6a9c89c0566479ff219320ca691f2505631ebacbe513bcc8108R268-R270

Fix:
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-05-20 23:11:47 +02:00
Matt Farina
c5249c1f8d
Revert "fix (helm) : toToml` renders int as float [ backport to v3 ]" 
This change has caused issues with numerous charts around things
unrelated to toml. This is because of functions like typeIs/typeOf
being used and acted upon.

The change caused a significant regression.

Closes #30880

Signed-off-by: Matt Farina <matt@mattfarina.com>
 2025-05-20 16:17:23 -04:00
Feng Cao
afefca8b2d chore: update generalization warning message 
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
 2025-05-16 15:50:18 +09:30
Feng Cao
eb5b6d5047 fix: move warning to top of block 
Emit the warning first to ensure it's always logged. This clarifies that any following errors are due to using a local chart instead of a remote repository.

Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
 2025-05-13 17:51:49 +09:30
Feng Cao
6b5c94475d fix: replace fmt warning with slog 
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
 2025-05-11 02:46:50 +09:30
Feng Cao
247bf7c2e0 fix: add warning when ignore repo flag 
Signed-off-by: Feng Cao <24779889+shfc@users.noreply.github.com>
 2025-05-11 01:48:39 +09:30
George Jenkins
b4e06a11d2
Merge pull request #30658 from helm/gjenkins/backport_12912 
[v3 backport] feat: add httproute from gateway-api to create chart template
 2025-05-06 20:51:07 -07:00
George Jenkins
a69eaf6098
Merge pull request #30764 from nvanthao/backport-30673 
v3 backport: Process all hook deletions on failure
 2025-05-06 10:57:16 -07:00
Robert Sirchia
94044595c7
bump version to v3.18.0 
(cherry picked from commit 74c3d1dc0de0335f941362c80447871e7d6bc78e)
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
 2025-05-05 16:09:20 -04:00
Terry Howe
cdd7c105a6 docs: Note about http fallback for OCI registries 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-04-26 10:00:30 -06:00
Scott Rigby
e4bc4a31b9
Merge pull request #30768 from banjoh/em/fix-take-ownership 
v3 backport - fix --take-ownership
 2025-04-21 10:45:45 -04:00
Benoit Tigeot
087fa18276
Bump toml 
Looking at the [toml diff](https://github.com/BurntSushi/toml/compare/v1.4.0...v1.5.0). I think it's safe to change the test here.

For main: https://github.com/helm/helm/pull/30775

Closes: https://github.com/helm/helm/pull/30683
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-04-19 09:06:19 +02:00
Evans Mungai
0906fe7f6b
Add install test for TakeOwnership flag 
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
 2025-04-17 18:19:27 +01:00
Patrick Seidensal
4ee3a19e9a
Fix --take-ownership 
If a resource exists in the cluster and is to be adopted by helm install
--take-ownership, it is left unchanged while helm reports the
installation to have succeeded.

This is due to CRs and CRDs being merged without three-way-merge, which
results in an empty patch.

By using a three-way-merge transparently when --take-ownership is used,
the helm behaves as expected without breaking previous behavior.

Fixes #30622

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
 2025-04-17 17:55:06 +01:00
Gerard Nguyen
0a800e84b0 backport #30673 to dev-v3 
Signed-off-by: Gerard Nguyen <gerard@replicated.com>
 2025-04-17 10:11:10 +10:00
Matt Farina
3ce10e4f81
Unarchiving fix 
Signed-off-by: Matt Farina <matt@mattfarina.com>
(cherry picked from commit 7cc4dcf94ee410c8e0d64f3e726dda199c24ccb2)
 2025-04-09 09:23:13 -04:00
Benoit Tigeot
422c58e4a2
Fix typo 
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-03-20 21:44:13 +01:00
Benoit Tigeot
5e7f12d4c3
Report as debug log, the time spent waiting for resources 
Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
 2025-03-19 23:09:25 +01:00
Terry Howe
1435ec7c77 Update pkg/registry/fallback.go 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-03-14 08:46:25 -06:00
Terry Howe
674e882c88 automatic fallback to http 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-03-14 08:46:25 -06:00
Terry Howe
c188441757 chore(oci): upgrade to ORAS v2 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
 2025-03-14 08:46:18 -06:00
Henrik Gerdes
bd1b67b082 feat: add httproute from gateway-api to create chart template 
Adds the HTTPRoute from https://gateway-api.sigs.k8s.io/reference/spec/ to the example getting started chart.

Signed-off-by: Henrik Gerdes <hegerdes@outlook.de>
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
 2025-03-12 10:27:53 -07:00
Scott Rigby
bcb83e465f
Fix cherry-pick helm.sh/helm/v4 -> helm.sh/helm/v3 
Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-02-21 19:19:39 -05:00
Chris Berry
2aa90b8f26
Refactor based on review comment 
Signed-off-by: Chris Berry <bez625@gmail.com>
 2025-02-21 19:00:41 -05:00
Chris Berry
5739197faa
Refactor based on review comment 
Signed-off-by: Chris Berry <bez625@gmail.com>
 2025-02-21 19:00:41 -05:00
Chris Berry
b8e13878fc
Add HookOutputFunc and generic yaml unmarshaller 
Signed-off-by: Chris Berry <bez625@gmail.com>
 2025-02-21 19:00:41 -05:00
Scott Rigby
97b0e11871
clarify fix error message 
Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-02-21 19:00:41 -05:00
Scott Rigby
2f79afb0a3
fix err check 
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-02-21 19:00:40 -05:00
Scott Rigby
c77f4ec6c4
remove comments about previous functionality 
Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-02-21 19:00:40 -05:00
Scott Rigby
3cd6afe845
add short circuit return 
Co-authored-by: George Jenkins <gvjenkins@gmail.com>
Signed-off-by: Scott Rigby <scott@r6by.com>
 2025-02-21 19:00:40 -05:00