upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-04-15 21:59:50 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
6796 commits 65 branches 249 tags 137 MiB
Commit graph

418 commits

Author SHA1 Message Date
Matt Farina
863bc74e5a
Update to func handling 
Signed-off-by: Matt Farina <matt@mattfarina.com>
 2023-02-03 15:36:32 -05:00
Matt Farina
36e18fa6e1
Fix improper use of Table request/response to k8s API 
Fixes #11712

A change was made that when validation was turned off the Kubernetes
packages were building objects as a Table type. This was done for
display purposes. When details about the objects was going to be
printed as part of #10912.

This broke rollback, and possibly other functionality, as a Table
type was returned in some cases that needed the regular object.
This caused things to break silently.

The fix involved adding in a new Function (and interface) to
query for tables instead of the objects themselves. There was not
a clean way to add it to the existing function that covered all
cases.

A second problem was noticed along the way. When data was output
via status as YAML or JSON it was in the form of a table rather
than the objects themselves. This did not reflect expectations
and did not match the functionality in kubectl. The code was
updated to return a table when that was presented and the objects
when they are being output for YAML or JSON. The API also supports
this handling to SDK users can replicate this functionality.

API changes made here were never released. The functions were
developed for this release of Helm and only ever appeared in an
RC. In this case, they can be changed.

Signed-off-by: Matt Farina <matt.farina@suse.com>
 2023-01-12 08:38:10 -05:00
Matt Farina
6487d43965
Merge pull request #11672 from VaibhavSharma-47/feature 
[CMD/PKG] Adopted resource not replaced when using upgrade --install --force
 2023-01-09 20:48:08 -05:00
Vaibhav Sharma
3181c7ddad fix adopted resource not replaced 
Signed-off-by: Vaibhav Sharma <17532va@gmail.com>
 2022-12-24 00:19:06 +05:30
Soujanya Mangipudi
038cc4a0ca
Merge branch 'main' into main 
Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>
 2022-12-12 10:48:20 -08:00
cui fliter
09d3f31358 fix a few function names on comments 
Signed-off-by: cui fliter <imcusg@gmail.com>
 2022-10-17 20:41:59 +08:00
Soujanya Mangipudi
ffa19a4b5d Addressing review comments - move printing code out of client.go 
Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

fix circleci tests

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

fix formatting errors

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

fix tests

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

fix tests

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

fix gofmt issue

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>
 2022-09-09 13:29:19 -07:00
Soujanya Mangipudi
20e3577543 Addressing review comments: 
Extend Interface with new InterfaceResources to avoid breaking changes
Move change to staus command behind --show-resources flag

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>
 2022-09-09 13:28:57 -07:00
Soujanya Mangipudi
9d5be803bc feat(helm): Supporting helm3 to show up resource names that were deployed as part of release in helm status command 
Creating a new PR based on this existing stale PR https://github.com/helm/helm/pull/7728

Signed-off-by: Soujanya Mangipudi <somangip@microsoft.com>

# Conflicts:
#	go.sum
 2022-09-09 13:28:48 -07:00
Martin Hickey
f08db5c899
Merge pull request #10834 from stan-sz/stan-sz/10285 
Log error message on failed download
 2022-08-12 09:57:16 +01:00
Martin Hickey
1d15ad7ea4
Merge pull request #10506 from suzaku/support-no-headers 
Add support for`helm list --no-headers`
 2022-08-12 09:55:31 +01:00
Dominic Evans
7c74f1dd02 fix: improve logging & safety of statefulSetReady 
Confirm that the current and updated revision numbers also match as part
of the readiness check. Add coverage for readiness scenarios where
StatefulSet status does not reflect the most recent generation of the
StatefulSet yet.

Also add additional logging around the sts transitions from non-ready to
ready.

Fixes: #10163

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
 2022-06-28 09:48:17 +01:00
Matthew Fisher
2ae4937e42
Merge pull request #10762 from yxxhero/fix_registry_config_issue 
fix --registry-config issue
 2022-05-13 10:08:04 -07:00
Matthew Fisher
e54e24cc90
Merge pull request #10852 from IamMayankThakur/main 
Fixed helm uninstall not deleting the resource.
 2022-05-13 10:05:52 -07:00
Matt Farina
2cd709c4a6
Merge pull request #10106 from presztak/lint_quiet_flag 
feat(*): add --quiet flag to 'helm lint'
 2022-05-06 16:30:38 -04:00
Martin Hickey
c477d697ec
Merge pull request #10458 from SimonAlling/remove-AssertGoldenBytes 
Remove AssertGoldenBytes test helper
 2022-04-29 09:37:23 +01:00
Mayank Thakur
fe00c9296d Fixed helm uninstall not deleting the resource. 
* Added `nil` check for returned err.
  * Return in case of `err` when deleting the release

Signed-off-by: Mayank Thakur <thakurmayank88@gmail.com>
 2022-04-12 12:55:47 +05:30
Graham Reed
82a2a2e85c Populate Capabilities.HelmVersion during install 
Signed-off-by: Graham Reed <greed@7deadly.org>
 2022-04-11 14:33:00 +01:00
stan-sz
6c55d9e3e9 Fix linter 
Signed-off-by: GitHub <noreply@github.com>
 2022-04-11 09:14:26 +00:00
stan-sz
a7e4ae752a Update install.go 
Feedback from PR

Signed-off-by: GitHub <noreply@github.com>
 2022-04-11 09:00:48 +00:00
stan-sz
660e4ffe7a Log error message on failed download 
Signed-off-by: GitHub <noreply@github.com>
 2022-04-11 09:00:48 +00:00
suzaku
d76f86b01c Add support helm list --no-headers 
Signed-off-by: suzaku <satorulogic@gmail.com>

Add test

Signed-off-by: suzaku <satorulogic@gmail.com>

Revert change to value semantic

Signed-off-by: satoru <satorulogic@gmail.com>
 2022-03-26 09:07:18 +08:00
yxxhero
9f199b6517 fix --registry-config issue 
Signed-off-by: yxxhero <aiopsclub@163.com>
 2022-03-12 16:56:23 +08:00
Matthew Fisher
e9abdc5efe
Merge pull request #9751 from cndoit18/fix-issue-9747 
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations
 2022-03-11 12:39:09 -08:00
Eng Zer Jun
2e3e22a003
test: use T.TempDir to create temporary test directory 
The directory created by `T.TempDir` is automatically removed when the
test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2022-02-12 13:54:54 +08:00
Matt Farina
1ec0aacb88
Merge pull request #10486 from gridai/fix-install-leak 
Fix install memory/goroutine leak
 2022-01-27 15:03:58 -05:00
Piotr Resztak
383086d397 feat(*): add --quiet flag to 'helm lint' 
Quiet flag reduce the verbosity, such that the only text
that is written to the console is lint warnings/errors

Closes #9994

Signed-off-by: Piotr Resztak <piotr.resztak@gmail.com>
 2022-01-20 17:21:03 +01:00
David Peraza
9661e39dce Moving uploader and pusher out of action into pkg 
Signed-off-by: David Peraza <dperaza@redhat.com>
 2022-01-13 08:22:51 -05:00
David Peraza
7cab1a09e3 Move all the remainder module out of experimental. 
All the experimental modules were moved to pkg/action

Signed-off-by: David Peraza <dperaza@redhat.com>
 2022-01-12 22:51:32 -05:00
Thomas Runyon
353d74e967 refactor internal/experimental/registry to pkg/registry 
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
 2022-01-12 21:49:26 -05:00
Matt Farina
548ec55cf9
Fix panic with OCI for install, upgrade, and show 
When range support for OCI went in via #10527 it created a situation
where some lookups for a chart could cause a panic. This change
makes sure the registry client is available to lookup OCI charts

Signed-off-by: Matt Farina <matt.farina@suse.com>
 2022-01-12 21:30:27 -05:00
Andrew Block
1a9cb93551
Handling name of OCI file 
Signed-off-by: Andrew Block <andy.block@gmail.com>
 2022-01-12 15:49:12 -06:00
Scott Rigby
4d50526a2b
Move OCI tag semver range logic from OCIGetter to ChartDownloader 
Signed-off-by: Scott Rigby <scott@r6by.com>
 2022-01-12 14:36:54 -05:00
Andrew Block
4f62d3dc1b
Started work on 'helm pull' 
Signed-off-by: Andrew Block <andy.block@gmail.com>
 2022-01-11 21:47:03 -05:00
Andrew Block
df98e18eb7
Working oci code without providing versions 
Signed-off-by: Andrew Block <andy.block@gmail.com>
 2022-01-11 21:47:03 -05:00
mengjiao.liu
160da867d0 validate release name during install 
Signed-off-by: mengjiao.liu <mengjiao.liu@daocloud.io>
 2021-12-29 14:45:05 +08:00
Neven Miculinic
5059ae843e Fix install memory/goroutine leak 
Signed-off-by: Neven Miculinic <neven.miculinic@gmail.com>
 2021-12-20 10:17:38 +01:00
Simon Alling
dd5db7bc40 Remove AssertGoldenBytes test helper 
The test suite is thereby simplified somewhat.

Signed-off-by: Simon Alling <alling.simon@gmail.com>
 2021-12-13 10:56:45 +01:00
Jerome Küttner
9a492f8240 Channel should remain open if there is still a routine that wants to write into it 
Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
 2021-12-06 18:07:47 +01:00
Jerome Küttner
ad3d2cc8ef Fix memory leak in upgrade action 
fixes helm/helm#10439

Signed-off-by: Jerome Küttner <j.kuettner@mittwald.de>
 2021-12-06 17:54:46 +01:00
cndoit18
94dc605968
fix(rollback): fix helm rollback doesn't have meta.helm.sh annotations 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
 2021-11-30 10:45:34 +08:00
Matthew Fisher
a8d33e7df4
Merge pull request #9918 from cndoit18/fix-issue-9915 
fix(install): fix 9915
 2021-11-26 08:47:31 -08:00
Timofey Kirillov
7f68bfa1fa
fix: added resource info into the validation error 
Signed-off-by: Timofey Kirillov <timofey.kirillov@flant.com>
 2021-11-12 19:00:43 +03:00
Guangwen Feng
9b7a45a384 Fix a golint issue caused by typo 
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
 2021-11-01 17:39:58 +08:00
Alexey Igrychev
5753f61ae3 docs: fix typo Charts.yaml 
Signed-off-by: Alexey Igrychev <alexey.igrychev@flant.com>
 2021-10-07 16:50:25 +01:00
cndoit18
da15d96a68
fix(install): if subcharts are disabled, the CRD for subcharts should not be installed 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
 2021-09-01 13:57:46 +08:00
Matt Farina
accf82ba1c
Merge pull request #9180 from Moser-ss/feature-handle-SIGINT 
Handle SIGTERMs during helm upgrade and helm install
 2021-08-30 18:18:13 -04:00
Matt Farina
2062a59566
Merge pull request #9702 from mikeshng/uninstall-wait 
feat: add optional boolean '--wait' flag to 'uninstall' command.
 2021-08-30 17:43:50 -04:00
Josh Dolitsky
caa97158d0
Revert moving registry actions back to pkg/ 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
 2021-08-30 15:54:42 -04:00
Josh Dolitsky
77750962d5
Move registry actions back to pkg/ 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
 2021-08-30 11:24:18 -04:00