Commit graph

3249 commits

Author SHA1 Message Date
Luna Stadler
1031b67fff Fix helm pull untar dir check with repo urls
The existing check worked for `helm pull downloaded-repo/chart-name`,
but often does not work when using `--repo-url`, depending on the urls
used by the charts.

Signed-off-by: Luna Stadler <luc@spreadshirt.net>
2025-07-20 16:10:27 +02:00
Robert Sirchia
4b8e61093d
Merge commit from fork
Updating link handling
2025-07-08 15:16:27 -04:00
George Jenkins
d21a8a04cb
Merge pull request #31029 from gjenkins8/gjenkins/k8s_yaml_struct
chore(refactor): Privatize 'k8sYamlStruct'
2025-07-07 14:28:30 -07:00
Matt Farina
76fdba4c8c
Updating link handling
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-07-07 10:09:25 -04:00
George Jenkins
bbea98ed6b
Merge pull request #30898 from fidelity-contributions/fix-issue-13198
Fix issue 13198
2025-07-06 11:39:38 -07:00
George Jenkins
4c674728d2 Privatize 'k8sYamlStruct'
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-07-05 11:48:22 -07:00
George Jenkins
edd0dabe02
Merge pull request #31021 from zachburg/test_temp_dir
Update tests in create_test.go and package_test.go to work in a temp directory
2025-07-04 17:21:23 -07:00
Matt Farina
e8be2e540d
Merge pull request #31023 from gjenkins8/gjenkins/rm_recreate_pods
Remove deprecated '--create-pods' flag
2025-07-03 11:07:20 -04:00
George Jenkins
a3bcc5b184 fix: 'TestRunLinterRule' stateful test
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-07-02 21:14:35 -07:00
George Jenkins
5283915c57 Remove deprecated '--create-pods' flag
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
2025-07-02 20:18:34 -07:00
Zach Burgess
eaf40b4b4f Call ensure.HelmHome() in package_test.go
Signed-off-by: Zach Burgess <zachburg@google.com>
2025-07-02 16:20:45 -07:00
Matt Farina
9517cfc5ce
Merge pull request #31009 from tpresa/test-coverage-pusher
test: increase test coverage for pkg/pusher
2025-07-02 15:37:55 -04:00
Zach Burgess
c48a3435f5 Remove unnecessary calls for changing directory to helmpath.CachePath.
This was only set on some tests in create_test.go and isn't
affecting the test.

Signed-off-by: Zach Burgess <zachburg@google.com>
2025-07-02 09:30:59 -07:00
Zach Burgess
3b26ddc22b Update tests in create_test.go and package_test.go to work in a temp dir.
Signed-off-by: Zach Burgess <zachburg@google.com>
2025-07-01 15:34:27 -07:00
Thiago Presa
afd63fed77 test: increase test coverage for pkg/pusher
Signed-off-by: Thiago Presa <thiago.addevico@gmail.com>
2025-07-01 17:16:36 -03:00
Matt Farina
f0cf9c28f0
Move logging setup to be configurable
Signed-off-by: Matt Farina <matt.farina@suse.com>
2025-07-01 15:51:25 -04:00
curlwget
bfc1af68fb chore: fix function in comment
Signed-off-by: curlwget <curlwget@icloud.com>
2025-06-24 15:48:08 +08:00
George Jenkins
a2a0935cba
Merge pull request #30900 from unguiculus/issue-12952
Add timeout flag to repo add and update commands
2025-06-22 18:00:57 -07:00
Robert Sirchia
ba0fbdeb57
Merge pull request #30979 from TerryHowe/oras-v2-login-for-v4
fix: OAuth username password login for v4
2025-06-17 15:06:31 -04:00
Terry Howe
df482346db
fix: lint test SetEnv errors
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-15 08:50:39 -06:00
Terry Howe
47980159b3
fix: user username password for login
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-13 11:27:34 -06:00
manslaughter03
bc44614a78 fix: wrap run release test error in case GetPodLogs failed.
Signed-off-by: manslaughter03 <manslaughter03@gmail.com>
2025-06-11 00:45:34 +02:00
Terry Howe
744c6b5a97
fix: kube client create mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-10 09:28:52 -06:00
Ashmit Bhardwaj
e060fbe185 updated docs
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
2025-06-09 06:15:39 +00:00
Ashmit Bhardwaj
0389407cbc removed unnecessary binary file
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
2025-06-09 06:15:39 +00:00
Ashmit Bhardwaj
b305a501e8 added documentation and test cases for api-versions flag
Signed-off-by: Ashmit Bhardwaj <ashmit.bhardwaj@fmr.com>
2025-06-09 06:15:39 +00:00
Terry Howe
93ec064640
fix: repo update cmd mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-06-06 06:47:50 -06:00
acceptacross
9623fb80f1 chore: fix some function names in comment
Signed-off-by: acceptacross <csqcqs@gmail.com>
2025-06-04 23:54:30 +08:00
Matt Farina
7031000b7d
Merge pull request #30955 from carloslima/fix-test-deleting-local-directories
Fix tests deleting XDG_DATA_HOME
2025-06-04 09:33:40 -06:00
Scott Rigby
069b525332
Merge pull request #13586 from jessesimpson36/cleaner-stacktraces
fix: add formatting for errors to make multiline stacktraces in helm templates
2025-06-03 21:37:54 -04:00
Carlos Lima
f8204031f1 Fix tests deleting XDG_DATA_HOME
That includes ~/.local/share/keyrings which was the most immediatelly
visible effect.

Signed-off-by: Carlos Lima <carlos@cpan.org>
2025-06-04 09:01:47 +08:00
Robert Sirchia
c0aa690c90
Merge pull request #30909 from jinjiadu/main
refactor: replace HasPrefix+TrimPrefix with CutPrefix
2025-06-03 15:59:11 -06:00
Scott Rigby
e2630d1aba
Merge pull request #30939 from TerryHowe/action-hooks-delete-policy-mutex
fix: action hooks delete policy mutex
2025-06-03 15:04:57 -04:00
Scott Rigby
de745ea34b
Merge pull request #12581 from Nordix/considerAllGroupVersionKind
Consider full GroupVersionKind when matching resources
2025-06-03 15:02:18 -04:00
Scott Rigby
e8c1acf228
Merge pull request #30809 from mmorel-35/usetesting
chore: enable usetesting linter
2025-06-03 14:57:06 -04:00
Scott Rigby
4023c3b5ff
Merge pull request #30917 from TerryHowe/oci-transport-debugging
fix: add debug logging to oci transport
2025-06-01 18:12:15 -04:00
Terry Howe
a8cbf3aa51 fix: action hooks delete policy mutex
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-30 08:12:20 -04:00
Matthieu MOREL
56a2bb4188 chore: enable usetesting linter
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
2025-05-30 08:12:11 +02:00
Terry Howe
6ab7aa3612 fix: legacy docker support broken for login
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-29 19:32:55 -04:00
Terry Howe
5fe7a87138 fix: add debug logging to oci transport
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <jinzha1@microsoft.com>
2025-05-29 07:12:06 -04:00
Benoit Tigeot
6df8eb3b3b
Fix flaky TestFindChartURL due to non-deterministic map iteration
The test was failing intermittently because Go's map iteration order
is randomized (see `range repos` in `findChartUrl`).
When looking up the `baz` chart with repository URL http://example.com/helm,
two repositories match due to trailing slash equivalence:

- testing-relative (URL: http://example.com/helm) - contains baz chart GOOD
- testing-relative-trailing-slash (URL: http://example.com/helm/) - does not contain baz chart.. NOT GOOD

The urlutil.Equal() function treats these URLs as equivalent, but
depending on which repository the random map iterator encounters
first, the test would either pass or fail with "entry not found".

So I changed the third test case from baz to foo chart, since foo exists
in both matching repositories. This eliminates the race condition while
preserving all test expectations and logic.

`findChartURL()` iterates over a map without deterministic
ordering, causing the first-match-wins behavior to be non-deterministic
when multiple repositories match the same URL pattern.

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-28 19:02:42 +02:00
Scott Rigby
d4e58c54ba
Merge pull request #30928 from TerryHowe/fix-plugin-install-no-internet
fix: plugin installer test with no Internet
2025-05-28 10:27:56 -04:00
Terry Howe
cc39d2428f fix: plugin installer test with no Internet
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
2025-05-27 13:34:37 -06:00
Benoit Tigeot
b2fd91b8d0
Adapt error of invalid json schema with the new expected output
Closes: https://github.com/helm/helm/pull/30907

To be able to upgrade to v6.0.2 for jsonschema lib we need to upgrade
this test.

I am wondering if it's related to this commit:
86cca28795

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
2025-05-26 09:44:02 +02:00
Reinhard Nägele
d448cf1943 Add timeout flag to repo add and update flags
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

# Conflicts:
#	pkg/cmd/repo_update.go
2025-05-26 07:31:55 +02:00
jinjiadu
6f8e9e09a4 refactor: replace HasPrefix+TrimPrefix with CutPrefix
Signed-off-by: jinjiadu <jinjiadu@aliyun.com>
2025-05-24 13:23:03 +08:00
Robert Sirchia
b7e127dd6b
amending missed line to delete
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-05-23 16:22:39 -04:00
Robert Sirchia
937c533e37
forward porting 30902
Signed-off-by: Robert Sirchia <rsirchia@outlook.com>
2025-05-23 16:19:03 -04:00
Robert Sirchia
52dddba759
Merge pull request #30894 from benoittgt/fix-#30881-main
Prevent push cmd failure in 3.18 by handling version tag resolution in ORAS memory store
2025-05-23 15:51:14 -04:00
Robert Sirchia
83c26845ad
Merge pull request #30904 from benoittgt/document-ideal-registry-login-command
[Doc] Help users avoid specifying URL scheme and path with `helm registry`
2025-05-23 08:06:12 -04:00