upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(CONTRIBUTING): added not about who merges a PR

Browse source 
A piece of folk knowledge got lost somewhere along the way: Core
contributors should merge their own PRs.
This commit is contained in:
Matt Butcher 2017-07-11 15:47:21 -06:00
parent 0f8abb21a8
commit df13268e0b
No known key found for this signature in database
GPG key ID: DCD5F5E5EF32C345
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CONTRIBUTING.md
View file

@ -143,6 +143,10 @@ Like any good open source project, we use Pull Requests to track code changes
- PRs should stay open until merged or if they have not been active for more than 30 days.
This will help keep the PR queue to a manageable size and reduce noise. Should the PR need
to stay open (like in the case of a WIP), the `keep open` label can be added.
- If the owner of the PR is listed in `OWNERS`, that user **must** merge their own PRs
or explicitly request another OWNER do that for them.
- If the owner of a PR is _not_ listed in `OWNERS`, any core committer may
merge the PR once it is approved.
#### Documentation PRs
Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the