upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #3491 from oilbeater/fix-defer-in-loop

Browse source 
defer in loop may cause resource leak
This commit is contained in:
Matthew Fisher 2018-02-27 19:52:00 +00:00 committed by GitHub
commit 86ae040bfa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/chartutil/expand.go
View file

@ -63,11 +63,12 @@ func Expand(dir string, r io.Reader) error {
if err != nil {
return err
}
defer file.Close()
_, err = io.Copy(file, tr)
if err != nil {
file.Close()
return err
}
file.Close()
}
return nil
}