upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-22 01:45:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(registry): remove pre-Go-1.20 transport cloner fallback

Browse source 
Helm now requires Go 1.26 (#32078); the cloner[T] type-assertion fallback
in transport.go was a defensive shim for Go versions before
http.Transport.Clone() existed. The fallback path is unreachable on
supported Go versions.

Refs: #31386
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
This commit is contained in:
Ogulcan Aydogan 2026-04-30 14:35:16 +01:00
parent 96c152cb1a
commit 73f71bceae
No known key found for this signature in database
GPG key ID: 00C439F668BFC3F6
1 changed files with 3 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pkg/registry/transport.go
View file

@ -52,22 +52,10 @@ type LoggingTransport struct {
// NewTransport creates and returns a new instance of LoggingTransport
func NewTransport(debug bool) *retry.Transport {
type cloner[T any] interface {
Clone() T
}
// try to copy (clone) the http.DefaultTransport so any mutations we
// perform on it (e.g. TLS config) are not reflected globally
// follow https://github.com/golang/go/issues/39299 for a more elegant
// solution in the future
// clone http.DefaultTransport so mutations (e.g. TLS config) are not
// reflected globally
transport := http.DefaultTransport
if t, ok := transport.(cloner[*http.Transport]); ok {
transport = t.Clone()
} else if t, ok := transport.(cloner[http.RoundTripper]); ok {
// this branch will not be used with go 1.20, it was added
// optimistically to try to clone if the http.DefaultTransport
// implementation changes, still the Clone method in that case
// might not return http.RoundTripper...
if t, ok := transport.(*http.Transport); ok {
transport = t.Clone()
}
if debug {