upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(helm): show failed releases by default

Browse source 
For 'helm list', this now shows both deployed and failed releases by
default.

Closes #1387
This commit is contained in:
Matt Butcher 2016-10-17 15:44:52 -06:00
parent d744a3d0a6
commit 51240d527b
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cmd/helm/list.go
View file

@ -33,8 +33,9 @@ import (
var listHelp = `
This command lists all of the releases.
By default, it lists only releases that are deployed. Flags like '--delete' and
'--all' will alter this behavior. Such flags can be combined: '--deleted --failed'.
By default, it lists only releases that are deployed or failed. Flags like
'--delete' and '--all' will alter this behavior. Such flags can be combined:
'--deleted --failed'.
By default, items are sorted alphabetically. Use the '-d' flag to sort by
release date.
@ -186,7 +187,7 @@ func (l *listCmd) statusCodes() []release.Status_Code {
// Default case.
if len(status) == 0 {
status = append(status, release.Status_DEPLOYED)
status = append(status, release.Status_DEPLOYED, release.Status_FAILED)
}
return status
}

11
cmd/helm/list_test.go
View file

@ -47,6 +47,15 @@ func TestListCmd(t *testing.T) {
},
expected: "NAME \tREVISION\tUPDATED \tSTATUS \tCHART \natlas\t1 \t(.*)\tDEPLOYED\tfoo-0.1.0-beta.1\n",
},
{
name: "list, one deployed, one failed",
args: []string{"-q"},
resp: []*release.Release{
releaseMock(&releaseOptions{name: "thomas-guide", statusCode: release.Status_FAILED}),
releaseMock(&releaseOptions{name: "atlas-guide", statusCode: release.Status_DEPLOYED}),
},
expected: "thomas-guide\natlas-guide",
},
{
name: "with a release, multiple flags",
args: []string{"--deleted", "--deployed", "--failed", "-q"},
@ -83,7 +92,7 @@ func TestListCmd(t *testing.T) {
}
re := regexp.MustCompile(tt.expected)
if !re.Match(buf.Bytes()) {
t.Errorf("%q. expected %q, got %q", tt.name, tt.expected, buf.String())
t.Errorf("%q. expected\n%q\ngot\n%q", tt.name, tt.expected, buf.String())
}
buf.Reset()
}