upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge pull request #6425 from AndiDog/helm-template-no-reachability-check

Browse source 
Fix reachability check which must be disabled for `helm template` (unless `--validate` is specified)
This commit is contained in:
Matthew Fisher 2019-09-24 08:36:53 -07:00 committed by GitHub
commit 3e891dbde9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/action/install.go
View file

@ -147,8 +147,11 @@ func (i *Install) installCRDs(crds []*chart.File) error {
//
// If DryRun is set to true, this will prepare the release, but not install it
func (i *Install) Run(chrt *chart.Chart, vals map[string]interface{}) (*release.Release, error) {
if err := i.cfg.KubeClient.IsReachable(); err != nil {
return nil, err
// Check reachability of cluster unless in client-only mode (e.g. `helm template` without `--validate`)
if !i.ClientOnly {
if err := i.cfg.KubeClient.IsReachable(); err != nil {
return nil, err
}
}
if err := i.availableName(); err != nil {