From 34d685f8bf77087b72ab704d366bf6519c66a5b9 Mon Sep 17 00:00:00 2001 From: Jacob LeGrone Date: Thu, 10 Oct 2019 18:22:36 -0400 Subject: [PATCH] feat(hooks): set default deletion policy to before-hook-creation Signed-off-by: Jacob LeGrone --- pkg/action/hooks.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkg/action/hooks.go b/pkg/action/hooks.go index d0498c9c6..638decff8 100644 --- a/pkg/action/hooks.go +++ b/pkg/action/hooks.go @@ -40,6 +40,15 @@ func (cfg *Configuration) execHook(rl *release.Release, hook release.HookEvent, sort.Sort(hookByWeight(executingHooks)) for _, h := range executingHooks { + // Set default delete policy to before-hook-creation + if h.DeletePolicies == nil || len(h.DeletePolicies) == 0 { + // TODO(jlegrone): Only apply before-hook-creation delete policy to run to completion + // resources. For all other resource types update in place if a + // resource with the same name already exists and is owned by the + // current release. + h.DeletePolicies = []release.HookDeletePolicy{release.HookBeforeHookCreation} + } + if err := cfg.deleteHookByPolicy(h, release.HookBeforeHookCreation); err != nil { return err }