upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-04-27 17:17:52 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

bugfix(tiller): replace + with - in Chart version to support Kubernetes constraint

Browse source
This commit is contained in:
Lachlan Evenson 2017-01-11 11:21:14 -08:00
parent 6f77869d41
commit 2e0f949d49
No known key found for this signature in database
GPG key ID: 40B69FE8539DFAB0
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/chartutil/create.go
View file

@ -97,7 +97,7 @@ kind: Deployment
metadata:
name: {{ template "fullname" . }}
labels:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
spec:
replicas: {{ .Values.replicaCount }}
template:
@ -128,7 +128,7 @@ kind: Service
metadata:
name: {{ template "fullname" . }}
labels:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
spec:
type: {{ .Values.service.type }}
ports:

4
pkg/chartutil/create_test.go
View file

@ -32,7 +32,7 @@ func TestCreate(t *testing.T) {
}
defer os.RemoveAll(tdir)
cf := &chart.Metadata{Name: "foo"}
cf := &chart.Metadata{Name: "foo", Version: "1.0.0+a056a76"}
c, err := Create(cf, tdir)
if err != nil {
@ -83,7 +83,7 @@ func TestCreateFrom(t *testing.T) {
}
defer os.RemoveAll(tdir)
cf := &chart.Metadata{Name: "foo"}
cf := &chart.Metadata{Name: "foo", Version: "1.0.0+a056a76"}
srcdir := "./testdata/mariner"
if err := CreateFrom(cf, tdir, srcdir); err != nil {