upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-05-28 04:35:48 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(helm): improve --dry-run for helm delete

Browse source
This commit is contained in:
Matt Butcher 2016-05-19 15:26:29 -06:00
parent 5ddae22a09
commit 1a3b563fb9
2 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cmd/helm/delete.go
View file

@ -2,7 +2,6 @@ package main
import (
"errors"
"fmt"
"github.com/kubernetes/helm/pkg/helm"
"github.com/spf13/cobra"
@ -37,13 +36,7 @@ func delRelease(cmd *cobra.Command, args []string) error {
return errors.New("command 'delete' requires a release name")
}
// TODO: Handle dry run use case.
if deleteDryRun {
fmt.Printf("DRY RUN: Deleting %s\n", args[0])
return nil
}
_, err := helm.UninstallRelease(args[0])
_, err := helm.UninstallRelease(args[0], deleteDryRun)
if err != nil {
return prettyError(err)
}

12
pkg/helm/helm.go
View file

@ -66,7 +66,17 @@ func UpdateRelease(name string) (*services.UpdateReleaseResponse, error) {
}
// UninstallRelease uninstalls a named release and returns the response.
func UninstallRelease(name string) (*services.UninstallReleaseResponse, error) {
func UninstallRelease(name string, dryRun bool) (*services.UninstallReleaseResponse, error) {
if dryRun {
// In the dry run case, just see if the release exists.
res, err := GetReleaseContent(name)
if err != nil {
return &services.UninstallReleaseResponse{}, err
}
return &services.UninstallReleaseResponse{Release: res.Release}, nil
}
u := &services.UninstallReleaseRequest{
Name: name,
}