upstream/helm
1
0
Fork 0
mirror of https://github.com/helm/helm.git synced 2026-04-23 15:17:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge pull request #11628 from dastrobu/Linting_error_on_null_in_dependencies_is_misleading_#11627

Browse source 
change linting error messages for null values in arrays
This commit is contained in:
Martin Hickey 2023-01-06 09:46:48 +00:00 committed by GitHub
commit 1819f1f616
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/chart/dependency.go
View file

@ -54,7 +54,7 @@ type Dependency struct {
// loaded.
func (d *Dependency) Validate() error {
if d == nil {
return ValidationError("dependency cannot be an empty list")
return ValidationError("dependencies must not contain empty or null nodes")
}
d.Name = sanitizeString(d.Name)
d.Version = sanitizeString(d.Version)

2
pkg/chart/metadata.go
View file

@ -35,7 +35,7 @@ type Maintainer struct {
// Validate checks valid data and sanitizes string characters.
func (m *Maintainer) Validate() error {
if m == nil {
return ValidationError("maintainer cannot be an empty list")
return ValidationError("maintainers must not contain empty or null nodes")
}
m.Name = sanitizeString(m.Name)
m.Email = sanitizeString(m.Email)

4
pkg/chart/metadata_test.go
View file

@ -82,7 +82,7 @@ func TestValidate(t *testing.T) {
nil,
},
},
ValidationError("dependency cannot be an empty list"),
ValidationError("dependencies must not contain empty or null nodes"),
},
{
&Metadata{
@ -94,7 +94,7 @@ func TestValidate(t *testing.T) {
nil,
},
},
ValidationError("maintainer cannot be an empty list"),
ValidationError("maintainers must not contain empty or null nodes"),
},
{
&Metadata{APIVersion: "v2", Name: "test", Version: "1.2.3.4"},