Recent fix of some HTX muxes to drain remaining data when the stream is in closed state revealed a bug, mainly due to a corner case of the HTX API. It is possible to have an empty HTX message with a parsing/internal error. In that case, the underlying buffer remains full. It is mandatory to prevent any buffer release and be sure the error will be handeled. On the other end, at several places, when data must be transfer from an HTX message to another one, we try to swap underlying buffers instead of performing a bloc-per-bloc copy. To do so, we rely on b_xfer() function. One condition is that the destination message must be empty. And here is the issue. The HTX message can be empty but the buffer can also be full because an HTX error was triggered earlier and not handled yet. In that case, attempting to call b_xfer() leads to a crash because the destination buffer is full. It is not expected to call b_xfer() if there is not enough space in the destination buffer. So, it appears the HTX API should be improved/fixed but first of all, the bug must be fixed. Especially because stable versions are also affected. The htx_is_empty_noerr() function was added to know if a HTX message is empty and no error was reported on it. And this function is now used, instead of htx_is_empty(), to know if we can safely swap the underlying buffers or not. the FCGI, H2 and QUIC multiplexers are concerned. The HTTP client and the applet API were also fixed while it seems harder to trigger the bug at these places. The fix must be backported to all supported versions. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README.md | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.
