mirror of
https://github.com/haproxy/haproxy.git
synced 2026-04-15 21:59:41 -04:00
HAProxy - Load balancer
80d0572a31
The quic-conn manages a buffer to store received QUIC packets. When the buffer wraps, the gap is filled until the end with junk and packets can be inserted at the start of the buffer. On the other end, deletion is implemented via quic_rx_pkts_del(). Packets are removed one by one if their refcount is nul. If junk is found, the buffer is emptied until its wrap. This seems to work in most cases but a bug was found in a particular case : on insertion if buffer gap is not at the end of the buffer. In this case, the gap was filled, which is useless as now the buffer is full and the packet cannot be inserted. Worst, on deletion, when junk is removed there is a risk to removed new packets. This can happens in the following case : 1. buffer contig space is too small, junk is inserted in the middle of it 2. on quic_rx_pkts_del() invocation, a packet is removed, but not the next one because its refcount is still positive. When a new packet is received, it will be stored after the junk. 3. on next quic_rx_pkts_del(), when junk is removed, all contig data is cleared, with newer packets data too. This will cause a transfer between a client and haproxy to be stalled. This can be reproduced with big enough POST requests. I triggered it with ngtcp2 and 10M of posted data. Hopefully, the solution of this bug is simple. If contig space is not big enough to store a packet, but the space is not at the end of the buffer, no junk is inserted and the packet is dropped as we cannot buffered it. This ensures that junk is only present at the end of the buffer and when removed no packets data is purged with it. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| ROADMAP | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)