mirror of
https://github.com/haproxy/haproxy.git
synced 2026-05-21 09:25:29 -04:00
When an async connect() fails in sock_conn_check(), it returns an errno that will not be retrieved later by a subsequent getsockopt(SO_ERROR). The problem is that this errno is then definitely lost. This is visible in the 4be_1srv_smtpchk_httpchk_layer47errors regtest that fails on certain systems (e.g. glibc 2.31 on arm32 running Linux 6.1), where the connect() error is systematically lost and the "Connection refused" is never seen in the check status. It also matches a few random reports of the past indicating that the connection error was sometimes not reported in the stats page in front of a down server. Ideally we should store errno in connections as soon as the error is seen. However this would require significant changes that are not acceptable yet for 3.4 nor stable releases. A more acceptable fix is to make use of the extra CO_ER_* flags set by conn_set_errno() as soon as the error is detected. This will recognize a sufficiently large number of errors and the check status will report them (here we'll have "ECONNREFUSED" in the check). Note that on systems where the error is seen synchronously, we can have "ECONNREFUSED (Connection refused)", but this is not a problem. This fix adds the missing conn_set_errno() call to sock_conn_check(), that is thus sufficient to catch this error. In addition, the two affected regtests were updated to search for ECONNREFUSED here. This might be backported to older releases if users request it, but it is probably not necessary. |
||
|---|---|---|
| .. | ||
| balance | ||
| cache | ||
| checks | ||
| compression | ||
| connection | ||
| contrib | ||
| converter | ||
| filters | ||
| http-capture | ||
| http-cookies | ||
| http-errorfiles | ||
| http-messaging | ||
| http-rules | ||
| http-set-timeout | ||
| jwt | ||
| log | ||
| lua | ||
| mailers | ||
| mcli | ||
| peers | ||
| pki | ||
| proxy | ||
| quic | ||
| sample_fetches | ||
| seamless-reload | ||
| server | ||
| spoe | ||
| ssl | ||
| startup | ||
| stats | ||
| stick-table | ||
| stickiness | ||
| stream | ||
| tcp-rules | ||
| webstats | ||
| README | ||
* Regression testing for HAProxy with VTest *
This little README file is about how to compile and run vtest test case files (VTC files)
to test HAProxy for any regression.
To do so, you will have to compile vtest program sources which depends on
Varnish cache application sources. vtest, formerly varnishtest, is a very useful
program which has been developed to test Varnish cache application. vtest has been
modified in collaboration with Varnish cache conceptor Poul-Henning Kamp to support
HAProxy in addition to Varnish cache.
See also: doc/regression-testing.txt
* vtest compilation *
$ git clone https://github.com/vtest/VTest2
$ cd VTest
$ make vtest
Then vtest program may be found at the root directory of vtest sources directory.
The Varnish cache manuals are located in 'man' directory of Varnish cache sources
directory. You will have to have a look at varnishtest(7) and vtc(7) manuals to
use vtest.
Some information may also be found in doc/regression-testing.txt in HAProxy
sources.
Note that VTC files for Varnish cache may be found in bin/varnishtest/tests directory
of Varnish cache sources directory which may be found here:
https://github.com/varnishcache/varnish-cache
* vtest execution *
You must set HAPROXY_PROGRAM environment variable to give the location
of the HAProxy program to test to vtest:
$ HAPROXY_PROGRAM=<my haproxy program> vtest ...
The HAProxy VTC files found in HAProxy sources may be run with the reg-tests
Makefile target. You must set the VTEST_PROGRAM environment variable to
give the location of the vtest program which has been previously compiled.
$ VTEST_PROGRAM=<my vtest program> make reg-tests
"reg-tests" Makefile target run scripts/run-regtest.sh script.
To get more information about this script run it with --help option.
Note that vtest is run with -t10 and -l option. -l option is to keep
keep vtest temporary directory in case of failed test cases. core files
may be found in this directory (if enabled by ulimit).
* vtest patches for HAProxy VTC files *
When producing a patch to add a VTC regression testing file to reg-tests directory,
please follow these simple rules:
- If your VTC file needs others files, if possible, use the same basename as that
of the VTC file,
- Put these files in a directory with the same name as the code area concerned
by the bug ('peers', 'lua', 'acl' etc).
Please note that most tests use a common set of timeouts defined by the
environment variable HAPROXY_TEST_TIMEOUT. As much as possible, for regular I/O
(i.e. not errors), please try to reuse that setting so that the value may
easily be adjusted when running in some particularly slow environments, or be
shortened to fail faster on developers' machines.