mirror of
https://github.com/haproxy/haproxy.git
synced 2026-04-22 14:49:45 -04:00
HAProxy - Load balancer
0e53cb07a5
This bug was reported by GH #2200 (coverity issue) as follows: *** CID 1516590: Resource leaks (RESOURCE_LEAK) /src/quic_tls.c: 159 in quic_conn_enc_level_init() 153 154 LIST_APPEND(&qc->qel_list, &qel->list); 155 *el = qel; 156 ret = 1; 157 leave: 158 TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc); >>> CID 1516590: Resource leaks (RESOURCE_LEAK) >>> Variable "qel" going out of scope leaks the storage it points to. 159 return ret; 160 } 161 162 /* Uninitialize <qel> QUIC encryption level. Never fails. */ 163 void quic_conn_enc_level_uninit(struct quic_conn *qc, struct quic_enc_level *qel) 164 { This bug was introduced by this commit which has foolishly assumed the encryption level memory would be released after quic_conn_enc_level_init() has failed. This is no more possible because this object is dynamic and no more a static member of the QUIC connection object. Anyway, this patch modifies quic_conn_enc_level_init() to ensure this is no more leak when quic_conn_enc_level_init() fails calling quic_conn_enc_level_uninit() in case of memory allocation error. quic_conn_enc_level_uninit() code was moved without modification only to be defined before quic_conn_enc_level_init() There is no need to backport this. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)