upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-11 20:06:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MINOR: peers: Do not ignore a protocol error for dictionary entries.

Browse source 
If we could not decode the ID of a dictionary entry from a peer update message,
we must inform the remote peer about such an error as this is done for
any other decoding error.
This commit is contained in:
Frdric Lcaille 2020-11-12 19:53:11 +01:00 committed by Willy Tarreau
parent d865935f32
commit f9e51beec1
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/peers.c
View file

@ -1609,8 +1609,11 @@ static int peer_treat_updatemsg(struct appctx *appctx, struct peer *p, int updt,
dc = p->dcache; dc = p->dcache;
if (*msg_cur == end) { if (*msg_cur == end) {
/* Dictionary entry key without value. */ /* Dictionary entry key without value. */
if (id > dc->max_entries) if (id > dc->max_entries) {
break; TRACE_PROTO("malformed message", PEERS_EV_UPDTMSG,
NULL, p, NULL, &id);
goto malformed_unlock;
}
/* IDs sent over the network are numbered from 1. */ /* IDs sent over the network are numbered from 1. */
de = dc->rx[id - 1].de; de = dc->rx[id - 1].de;
} }