upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-15 21:59:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MINOR: config: Alert about extra arguments for errorfile and errorloc

Browse source 
errorfile and errorloc directives expect excatly two arguments. But extra
arguments were just ignored while an error should be emitted. It is now
fixed.

This patch could be backported as far as 2.2 if necessary.
This commit is contained in:
Christopher Faulet 2025-01-03 10:10:08 +01:00
parent a785a20bef
commit f578811c4e
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/http_htx.c
View file

@ -1999,6 +1999,11 @@ static int proxy_parse_errorloc(char **args, int section, struct proxy *curpx,
ret = -1;
goto out;
}
if (*(args[3])) {
memprintf(errmsg, "%s : expects exactly two arguments.\n", args[0]);
ret = -1;
goto out;
}
status = atol(args[1]);
errloc = (strcmp(args[0], "errorloc303") == 0 ? 303 : 302);
@ -2066,6 +2071,11 @@ static int proxy_parse_errorfile(char **args, int section, struct proxy *curpx,
ret = -1;
goto out;
}
if (*(args[3])) {
memprintf(errmsg, "%s : expects exactly two arguments.\n", args[0]);
ret = -1;
goto out;
}
status = atol(args[1]);
msg = http_parse_errorfile(status, args[2], errmsg);