mirror of
https://github.com/haproxy/haproxy.git
synced 2026-02-19 02:29:31 -05:00
CLEANUP: task: move the barrier after clearing th_ctx->current
There's a barrier after releasing the current task in the scheduler. However it's improperly placed, it's done after pool_free() while in fact it must be done immediately after resetting the current pointer. Indeed, the purpose is to make sure that nobody sees the task as valid when it's in the process of being released. This is something that could theoretically happen if interrupted by a signal in the inlined code of pool_free() if the compiler decided to postpone the write to ->current. In practice since nothing fancy is done in the inlined part of the function, there's currently no risk of reordering. But it could happen if the underlying __pool_free() were to be inlined for example, and in this case we could possibly observe th_ctx->current pointing to something currently being destroyed. With the barrier between the two, there's no risk anymore.
This commit is contained in:
parent
eb41d768f9
commit
e7510d6230
1 changed files with 4 additions and 1 deletions
|
|
@ -605,8 +605,11 @@ unsigned int run_tasks_from_lists(unsigned int budgets[])
|
|||
else {
|
||||
done++;
|
||||
th_ctx->current = NULL;
|
||||
pool_free(pool_head_tasklet, t);
|
||||
/* signal barrier to prevent thread dump helpers
|
||||
* from dumping a task currently being freed.
|
||||
*/
|
||||
__ha_barrier_store();
|
||||
pool_free(pool_head_tasklet, t);
|
||||
continue;
|
||||
}
|
||||
} else {
|
||||
|
|
|
|||
Loading…
Reference in a new issue