upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-22 23:02:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

CLEANUP: Reduce scope of header_name in http_action_store_cache()

Browse source 
This variable is only needed deeply nested in a single location and clang's
static analyzer complains about a dead initialization. Reduce the scope to
satisfy clang and the human that reads the function.
This commit is contained in:
Tim Duesterhus 2021-01-02 22:47:16 +01:00 committed by William Lallemand
parent 8f7efcddd6
commit e2fff10a19
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/cache.c
View file

@ -994,7 +994,6 @@ enum act_return http_action_store_cache(struct act_rule *rule, struct proxy *px,
struct http_hdr_ctx ctx;
size_t hdrs_len = 0;
int32_t pos;
struct ist header_name = IST_NULL;
unsigned int vary_signature = 0;
/* Don't cache if the response came from a cache */
@ -1181,7 +1180,7 @@ enum act_return http_action_store_cache(struct act_rule *rule, struct proxy *px,
* future conditional requests to be able to perform ETag
* comparisons. */
if (type == HTX_BLK_HDR) {
header_name = htx_get_blk_name(htx, blk);
struct ist header_name = htx_get_blk_name(htx, blk);
if (isteq(header_name, ist("etag"))) {
object->etag_length = sz - istlen(header_name);
object->etag_offset = sizeof(struct cache_entry) + b_data(&trash) - sz + istlen(header_name);