upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-22 23:02:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

BUG/MEDIUM: htx: Be sure to have a buffer to perform a raw copy of a message

Browse source 
In htx_copy_msg(), if the destination buffer is empty, we perform a raw copy
of the message instead of a copy block per block. But we must be sure the
destianation buffer was really allocated. In other word, to perform a raw
copy, the HTX message must be empty _AND_ it must have some free space
available.

This function is only used to copy an HTTP reply (for instance, an error or
a redirect) in the buffer of the response channel. For now, we are sure the
buffer was allocated because it is a pre-requisite to call stream
analyzers. However, it may be a source of bug in future.

This patch may be backported as far as 2.3.
This commit is contained in:
Christopher Faulet 2022-02-01 18:11:50 +01:00
parent ea3e0355da
commit dc523e3b89
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/haproxy/htx.h
View file

@ -749,8 +749,8 @@ static inline int htx_expect_more(const struct htx *htx)
*/
static inline int htx_copy_msg(struct htx *htx, const struct buffer *msg)
{
/* The destination HTX message is empty, we can do a raw copy */
if (htx_is_empty(htx)) {
/* The destination HTX message is allocated and empty, we can do a raw copy */
if (htx_is_empty(htx) && htx_free_space(htx)) {
memcpy(htx, msg->area, msg->size);
return 1;
}