upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-21 06:06:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

MINOR: http_ext/7239: warn the user when fetch is not available

Browse source 
http option forwarded (rfc7239) supports sample expressions when
configuring 'host', 'for' and 'by' parameters.

However, since we are in a http-backend-only context, right after http
header is processed, we have a limited resolution scope for the sample
expression provided by the user.

To prevent any confusion, a warning is emitted when parsing the option
if the user relies on a sample expression (more precisely a fetch) which
would yield unexpected results at runtime when processing the option.
This commit is contained in:
Aurelien DARRAGON 2023-01-06 15:06:49 +01:00 committed by Christopher Faulet
parent 9ded834adc
commit d745a3f117
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/http_ext.c
View file

@ -1143,6 +1143,19 @@ int proxy_http_compile_7239(struct proxy *curproxy)
ha_free(&err);
cfgerr++;
}
else if (!(cur_expr->fetch->val & SMP_VAL_BE_HRQ_HDR)) {
/* fetch not available in this context: sample expr is resolved
* within backend right after headers are processed.
* (in http_process_request())
* -> we simply warn the user about the misuse
*/
ha_warning("%s '%s' [%s:%d]: in 'option forwarded' sample expression '%s' : "
"some args extract information from '%s', "
"none of which is available here.\n",
proxy_type_str(curproxy), curproxy->id,
curproxy->http.fwd.c_file, curproxy->http.fwd.c_line,
*expr_str, sample_ckp_names(cur_expr->fetch->use));
}
/* post parsing individual expr cleanup */
ha_free(expr_str);