upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-06-09 00:32:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

MINOR: server: don't read curr_used_conns multiple times

Browse source 
This one is added atomically and we reread it just after this, causing
a second memory load that is visible in the perf profile.
This commit is contained in:
Willy Tarreau 2021-03-03 18:12:11 +01:00
parent 4149168255
commit cc2672f48b
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
include/haproxy/server.h
View file

@ -247,16 +247,18 @@ static inline enum srv_initaddr srv_get_next_initaddr(unsigned int *list)
static inline void srv_use_conn(struct server *srv, struct connection *conn)
{
_HA_ATOMIC_ADD(&srv->curr_used_conns, 1);
unsigned int curr;
curr = _HA_ATOMIC_ADD(&srv->curr_used_conns, 1);
/* It's ok not to do that atomically, we don't need an
* exact max.
*/
if (srv->max_used_conns < srv->curr_used_conns)
srv->max_used_conns = srv->curr_used_conns;
if (srv->max_used_conns < curr)
srv->max_used_conns = curr;
if (srv->est_need_conns < srv->curr_used_conns)
srv->est_need_conns = srv->curr_used_conns;
if (srv->est_need_conns < curr)
srv->est_need_conns = curr;
}
static inline void conn_delete_from_tree(struct ebmb_node *node)