upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-06-09 00:32:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

CLEANUP: ncbmbuf: improve handling of memory allocation errors in unit tests

Browse source 
Found via cppcheck  --force --enable=all --output-file=haproxy.log :

src/ncbmbuf.c:192:9: warning: If memory allocation fails, then there is a possible null pointer dereference: area [nullPointerOutOfMemory]
src/ncbmbuf.c:373:9: warning: If memory allocation fails, then there is a possible null pointer dereference: data [nullPointerOutOfMemory]
src/ncbmbuf.c:546:9: warning: If memory allocation fails, then there is a possible null pointer dereference: data [nullPointerOutOfMemory]
This commit is contained in:
Ilia Shipitsin 2026-05-31 09:14:39 +02:00 committed by Willy Tarreau
parent a93b407811
commit c1d6973571
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/ncbmbuf.c
View file

@ -370,6 +370,12 @@ void test_ncbmb(void)
char *data = calloc(16384, 1);
struct ncbmbuf buf;
if (!area || !data) {
free(area);
free(data);
return;
}
memset(data, 0x11, 16384);
/* 7 bytes data // 1 byte bitmap (0xfe) */
@ -543,6 +549,12 @@ void test_ngtcp2_crypto(void)
char *data = calloc(16384, 1);
struct ncbmbuf buf;
if (!area || !data) {
free(area);
free(data);
return;
}
memset(data, 0x11, 16384);
buf = ncbmb_make(area, 16384, 0);