upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-06-08 16:23:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

BUG/MEDIUM: qmux: Close connection on invalid frame

Browse source 
In qcc_qmux_recv(), when calling qmux_parse_frm(), also treat negative
values as an error, and close the connexion. qmux_parse_frm() will
return -1 if the frame is of an invalid type, and we don't want to
process any further, or we will crash.
This commit is contained in:
Olivier Houchard 2026-05-28 22:01:01 +02:00 committed by Amaury Denoyelle
parent 41a20c1738
commit bda42604c0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/qcm_qmux.c
View file

@ -195,7 +195,7 @@ int qcc_qmux_recv(struct qcc *qcc)
buf_rec = b_make(b_orig(buf), b_size(buf),
b_head_ofs(buf), qcc->rx.rlen);
frm_ret = qmux_parse_frm(qcc, &buf_rec);
if (!frm_ret) {
if (frm_ret <= 0) {
/* TODO implement proper connection closure */
conn->flags |= CO_FL_ERROR;
goto out;