upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-06-09 00:32:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

MINOR: pools: reject creation of pools containing invalid chars in their name

Browse source 
In order to preventively avoid issues that complicate debugging, let's
report to developers early if a pool name is not acceptable. This patch
does it in create_pool_from_reg() which catches both direct and declared
registrations. Aside the previous case, this didn't catch any other
occurrence.
This commit is contained in:
Willy Tarreau 2026-06-08 08:54:37 +02:00
parent 172306c308
commit b9fa07bd20
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/pool.c
View file

@ -370,6 +370,13 @@ struct pool_head *create_pool_from_reg(const char *name, struct pool_registratio
return NULL;
}
if (invalid_char(name)) {
ha_alert("Pool '%s' declared at %s:%u contains invalid chars in its name and "
"cannot be registered. Please report to developers. Aborting.\n",
name, reg->file, reg->line);
return NULL;
}
extra_mark = (pool_debugging & POOL_DBG_TAG) ? POOL_EXTRA_MARK : 0;
extra_caller = (pool_debugging & POOL_DBG_CALLER) ? POOL_EXTRA_CALLER : 0;
extra = extra_mark + extra_caller;