upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-10 11:26:15 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

BUG/MINOR: ssl: Potential NULL deref in trace macro

Browse source 
'ctx' might be NULL when we exit 'ssl_sock_handshake', it can't be
dereferenced without check in the trace macro.

This was found by Coverity andraised in GitHub #3113.
This patch should be backported up to 3.2.
This commit is contained in:
Remi Tricot-Le Breton 2025-09-10 10:13:22 +02:00 committed by William Lallemand
parent e52e6f66ac
commit a316342ec6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ssl_sock.c
View file

@ -5909,7 +5909,7 @@ reneg_ok:
if (!conn->err_code)
conn->err_code = CO_ER_SSL_HANDSHAKE;
TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, ctx->ssl, &conn->err_code, &ctx->error_code);
TRACE_ERROR("handshake error", SSL_EV_CONN_HNDSHK|SSL_EV_CONN_ERR, conn, ctx->ssl, &conn->err_code, (ctx ? &ctx->error_code : NULL));
return 0;
}