upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-21 06:06:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

BUG/MINOR: h3: fix crash on h3s alloc failure

Browse source 
Do not emit a CONNECTION_CLOSE on h3s allocation failure. Indeed, this
causes a crash as the calling function qcs_new() will also try to emit a
CONNECTION_CLOSE which triggers a BUG_ON() on qcc_emit_cc().

This was reproduced using -dMfail.

This should be backported up to 2.7.
This commit is contained in:
Amaury Denoyelle 2023-04-19 11:49:16 +02:00
parent 93d2ebe9f3
commit 9bbfa72b67
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/h3.c
View file

@ -1707,7 +1707,6 @@ static int h3_attach(struct qcs *qcs, void *conn_ctx)
h3s = pool_alloc(pool_head_h3s);
if (!h3s) {
TRACE_ERROR("h3s allocation failure", H3_EV_H3S_NEW, qcs->qcc->conn, qcs);
qcc_emit_cc_app(qcs->qcc, H3_INTERNAL_ERROR, 1);
goto err;
}