upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-24 07:37:53 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MINOR: mworker: use after free when the PID not assigned

Browse source 
Commit 4528611 ("MEDIUM: mworker: store the leaving state of a process")
introduced a bug in the mworker_env_to_proc_list() function.

This is very unlikely to occur since the PID should always be assigned.
It can probably happen if the environment variable is corrupted.

No backport needed.
This commit is contained in:
William Lallemand 2019-05-14 11:15:18 +02:00 committed by William Lallemand
parent f983d00a1c
commit 920fc8bbe4
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/mworker.c
View file

@ -180,14 +180,15 @@ void mworker_env_to_proc_list()
}
}
if (child->pid) {
/* this is a process inherited from a reload that should be leaving */
child->options |= PROC_O_LEAVING;
LIST_ADDQ(&proc_list, &child->list);
} else {
free(child->id);
free(child);
}
/* this is a process inherited from a reload that should be leaving */
child->options |= PROC_O_LEAVING;
}
unsetenv("HAPROXY_PROCESSES");