upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-26 16:49:47 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

CLEANUP: dns: remove duplicated code in dns_validate_dns_response()

Browse source 
a reader pointer comparison to the end of the buffer was performed twice
while once is obviously enough.

backport status: this patch can be backported into HAProxy 1.6 (with some
modification. Please contact me)
This commit is contained in:
Baptiste Assmann 2017-08-21 16:11:32 +02:00 committed by Willy Tarreau
parent 60e9c264c9
commit 8d11236234
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/dns.c
View file

@ -1239,11 +1239,6 @@ int dns_validate_dns_response(unsigned char *resp, unsigned char *bufend, struct
return DNS_RESP_INVALID;
}
if (reader >= bufend) {
free_dns_answer_item(dns_answer_record);
return DNS_RESP_INVALID;
}
/* 2 bytes for record type (A, AAAA, CNAME, etc...) */
if (reader + 2 > bufend) {
free_dns_answer_item(dns_answer_record);