upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-15 21:59:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MAJOR: connections: Close the connection before freeing it.

Browse source 
In si_release_endpoint(), if the end point is a connection, because we don't
know which mux to use it, make sure we close the connection before freeing it,
or else, we'd have a fd left for polling, which would point to a now free'd
connection.

This should be backported to 1.9.
This commit is contained in:
Olivier Houchard 2018-12-19 23:21:46 +01:00 committed by Willy Tarreau
parent 822305067b
commit 8ab8a6eee5
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
include/proto/stream_interface.h
View file

@ -173,8 +173,11 @@ static inline void si_release_endpoint(struct stream_interface *si)
if (appctx->applet->release && si->state < SI_ST_DIS)
appctx->applet->release(appctx);
appctx_free(appctx); /* we share the connection pool */
} else if ((conn = objt_conn(si->end)))
} else if ((conn = objt_conn(si->end))) {
conn_stop_tracking(conn);
conn_full_close(conn);
conn_free(conn);
}
si_detach_endpoint(si);
}