upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-05-27 11:52:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

BUG/MINOR: tools: my_memspn/my_memcspn wrong cast causing incorrect byte reading

Browse source 
Both functions cast void * to int * and dereference, reading 4 bytes as an
integer instead of a single byte. This is passed to memchr() which expects a
byte value. On unaligned addresses this causes crashes on ARM/mips etc, and
search for the wrong byte on big endian platforms. Fixed to cast to
const unsigned char * and dereference a single byte. This is marked as
minor because these functions were added in 2.2 by commit 5eb96cbcbc
("MINOR: standard: Add my_memspn and my_memcspn") and have not been used
since then.
This commit is contained in:
Willy Tarreau 2026-04-26 23:00:38 +02:00
parent c6600d7835
commit 84cb8dd126
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/tools.c
View file

@ -3070,7 +3070,7 @@ size_t my_memspn(const void *str, size_t len, const void *accept, size_t acceptl
{
size_t ret = 0;
while (ret < len && memchr(accept, *((int *)str), acceptlen)) {
while (ret < len && memchr(accept, *((const unsigned char *)str), acceptlen)) {
str++;
ret++;
}
@ -3083,7 +3083,7 @@ size_t my_memcspn(const void *str, size_t len, const void *reject, size_t reject
size_t ret = 0;
while (ret < len) {
if(memchr(reject, *((int *)str), rejectlen))
if (memchr(reject, *((const unsigned char *)str), rejectlen))
return ret;
str++;
ret++;