upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-15 21:59:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MEDIUM: mt_list: Use atomic operations to prevent compiler optims

Browse source 
As a folow-up to f40f5401b9, explicitely
use atomic operations to set the prev and next fields, to make sure the
compiler can't assume anything about it, and just does it.

This should be backported after f40f5401b9 up to 2.8.
This commit is contained in:
Olivier Houchard 2025-10-24 12:43:47 +02:00 committed by Olivier Houchard
parent 2ec6df59bf
commit 837351245a
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
include/import/mt_list.h
View file

@ -264,8 +264,8 @@ static inline __attribute__((always_inline)) unsigned long mt_list_cpu_relax(uns
*/
static inline struct mt_list *mt_list_init(struct mt_list *el)
{
el->next = el;
el->prev = el;
__atomic_store_n(&el->next, el, __ATOMIC_RELAXED);
__atomic_store_n(&el->prev, el, __ATOMIC_RELAXED);
return el;
}
@ -491,8 +491,8 @@ static MT_INLINE struct mt_list *mt_list_behead(struct mt_list *lh)
break;
}
lh->next = lh;
lh->prev = lh;
__atomic_store_n(&lh->next, lh, __ATOMIC_RELAXED);
__atomic_store_n(&lh->prev, lh, __ATOMIC_RELAXED);
__atomic_thread_fence(__ATOMIC_RELEASE);
n->prev = p;
@ -645,8 +645,8 @@ static MT_INLINE long mt_list_delete(struct mt_list *el)
* somebody may be using it already.
*/
if (el != n) {
el->prev = el;
el->next = el;
__atomic_store_n(&el->prev, el, __ATOMIC_RELAXED);
__atomic_store_n(&el->next, el, __ATOMIC_RELAXED);
__atomic_thread_fence(__ATOMIC_RELEASE);
}