From 6617e769bfc58c8038e07f29325fde2ceb50a388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 25 Apr 2018 15:13:38 +0200 Subject: [PATCH] CLEANUP: cfgparse: Return asap from cfg_parse_peers(). Avoid useless code indentation. May be backported to 1.5 and newer. --- src/cfgparse.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/cfgparse.c b/src/cfgparse.c index d4677efd5..54e5d92c0 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -643,7 +643,10 @@ int cfg_parse_peers(const char *file, int linenum, char **args, int kwm) newpeer->sock_init_arg = NULL; HA_SPIN_INIT(&newpeer->lock); - if (strcmp(newpeer->id, localpeer) == 0) { + if (strcmp(newpeer->id, localpeer) != 0) + /* We are done. */ + goto out; + /* Current is local peer, it define a frontend */ newpeer->local = 1; cfg_peers->local = newpeer; @@ -687,7 +690,6 @@ int cfg_parse_peers(const char *file, int linenum, char **args, int kwm) err_code |= ERR_FATAL; goto out; } - } } /* neither "peer" nor "peers" */ else if (!strcmp(args[0], "disabled")) { /* disables this peers section */ curpeers->state = PR_STSTOPPED;