upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-06-08 16:23:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

MINOR: cli/server: don't take thread isolation to check for srv-removable

Browse source 
Thanks to the previous commits, we now know that "wait srv-removable"
does not require thread isolation, as long as 3372a2ea00 ("BUG/MEDIUM:
queues: Stricly respect maxconn for outgoing connections") and c880c32b16
("MINOR: stream: decrement srv->served after detaching from the list")
are present. Let's just get rid of thread_isolate() here, which can
consume a lot of CPU on highly threaded machines when removing many
servers at once.
This commit is contained in:
Willy Tarreau 2025-03-18 11:41:51 +01:00
parent aad8e74cb9
commit 6336b636f7
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/cli.c
View file

@ -2127,9 +2127,7 @@ static int cli_io_handler_wait(struct appctx *appctx)
if (ctx->cond == CLI_WAIT_COND_SRV_UNUSED) {
/* check if the server in args[0]/args[1] can be released now */
thread_isolate();
ret = srv_check_for_deletion(ctx->args[0], ctx->args[1], NULL, NULL, NULL);
thread_release();
if (ret < 0) {
/* unrecoverable failure */