upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-02-20 00:10:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

BUG/MEDIUM: balance source did not properly hash IPv6 addresses

Browse source 
The hash of IPv6 addresses was not properly aligned and resulted in the
last quarter of the address not being hashed. In practice, this is rarely
detected since MAC addresses are used in the second half. But this becomes
very visible with IPv6-mapped IPv4 addresses such as ::FFFF:1.2.3.4 where
the IPv4 part is never hashed.

This bug has been there forever, since introduction of "balance source" in
v1.2.11. The fix must then be backported to all stable versions.

Thanks to Alex Markham for reporting this issue to the list !
This commit is contained in:
Willy Tarreau 2012-03-31 19:53:37 +02:00
parent 51b5dcae85
commit 5dd7fa1f6b
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/backend.c
View file

@ -497,7 +497,6 @@ int assign_server(struct session *s)
clear_target(&s->target);
if (s->be->lbprm.algo & BE_LB_KIND) {
int len;
/* we must check if we have at least one server available */
if (!s->be->lbprm.tot_weight) {
err = SRV_STATUS_NOSRV;
@ -538,19 +537,21 @@ int assign_server(struct session *s)
switch (s->be->lbprm.algo & BE_LB_PARM) {
case BE_LB_HASH_SRC:
if (s->req->prod->addr.from.ss_family == AF_INET)
len = 4;
else if (s->req->prod->addr.from.ss_family == AF_INET6)
len = 16;
if (s->req->prod->addr.from.ss_family == AF_INET) {
srv = get_server_sh(s->be,
(void *)&((struct sockaddr_in *)&s->req->prod->addr.from)->sin_addr,
4);
}
else if (s->req->prod->addr.from.ss_family == AF_INET6) {
srv = get_server_sh(s->be,
(void *)&((struct sockaddr_in6 *)&s->req->prod->addr.from)->sin6_addr,
16);
}
else {
/* unknown IP family */
err = SRV_STATUS_INTERNAL;
goto out;
}
srv = get_server_sh(s->be,
(void *)&((struct sockaddr_in *)&s->req->prod->addr.from)->sin_addr,
len);
break;
case BE_LB_HASH_URI: