upstream/haproxy
1
0
Fork 0
mirror of https://github.com/haproxy/haproxy.git synced 2026-04-15 21:59:41 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

BUG/MINOR: quic: Dropped peer transport parameters

Browse source 
The call to quic_dflt_transport_params_cpy() is already first done by
quic_transport_params_init() which is a good thing. But this function was also
called each time we parsed a transport parameters with quic_transport_param_decode(),
re-initializing to default values some of them. The transport parameters concerned
by this bug are the following:
   - max_udp_payload_size
   - ack_delay_exponent
   - max_ack_delay
   - active_connection_id_limit
So, let's remove this call to quic_dflt_transport_params_cpy() which has nothing
to do here!
This commit is contained in:
Frédéric Lécaille 2022-05-03 15:55:17 +02:00
parent 8726d633d4
commit 5b988ebed1
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
include/haproxy/xprt_quic.h
View file

@ -607,7 +607,6 @@ static inline int quic_transport_param_decode(struct quic_transport_params *p,
{
const unsigned char *end = *buf + len;
quic_dflt_transport_params_cpy(p);
switch (type) {
case QUIC_TP_ORIGINAL_DESTINATION_CONNECTION_ID:
if (!server || len >= sizeof p->original_destination_connection_id.data)